[GitHub] [airflow] malthe commented on a change in pull request #20731: Truncate stack trace to DAG user code for exceptions raised during execution

[GitBox <gi...@apache.org>]

malthe commented on a change in pull request #20731:
URL: https://github.com/apache/airflow/pull/20731#discussion_r802468952



##########
File path: airflow/models/taskinstance.py
##########
@@ -1438,7 +1443,13 @@ def _execute_task_with_callbacks(self, context):
         """Prepare Task for Execution"""
         from airflow.models.renderedtifields import RenderedTaskInstanceFields
 
+        parent_pid = os.getpid()
+
         def signal_handler(signum, frame):
+            pid = os.getpid()
+            if pid != parent_pid:
+                os._exit(1)

Review comment:
       So that's because ... well it's a bit of an odd-ball, but it's motivated by a DAG in the test suite which forks inside DAG code.
   
   What happens then is that it returns back out to the calling framework, but we don't want to handle such a forked process coming back in, we just want to handle our own forked process.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org