You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "CharlieFRuan (via GitHub)" <gi...@apache.org> on 2024/08/07 07:36:41 UTC
[PR] [Web] Add TVMArgBool to ArgTypeCode [tvm]
CharlieFRuan opened a new pull request, #17251:
URL: https://github.com/apache/tvm/pull/17251
In a recent PR https://github.com/apache/tvm/pull/16183, `TVMArgTypeCode` introduced `TVMArgBool`. This PR is needed for the web runtime when a TVM packed function returns a bool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Web] Add TVMArgBool to ArgTypeCode [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on code in PR #17251:
URL: https://github.com/apache/tvm/pull/17251#discussion_r1706821288
##########
web/src/runtime.ts:
##########
@@ -2473,6 +2473,7 @@ export class Instance implements Disposable {
switch (tcode) {
case ArgTypeCode.Int:
case ArgTypeCode.UInt:
+ case ArgTypeCode.TVMArgBool:
return this.memory.loadI64(rvaluePtr);
Review Comment:
this would need to wait until https://github.com/apache/tvm/pull/17240, but once the new bool type lands yes this would be the case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Web] Add TVMArgBool to ArgTypeCode [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #17251:
URL: https://github.com/apache/tvm/pull/17251#issuecomment-2273219709
temp block this in light of https://github.com/apache/tvm/pull/16183#issuecomment-2273212033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Web] Add TVMArgBool to ArgTypeCode [tvm]
Posted by "CharlieFRuan (via GitHub)" <gi...@apache.org>.
CharlieFRuan commented on code in PR #17251:
URL: https://github.com/apache/tvm/pull/17251#discussion_r1706532336
##########
web/src/runtime.ts:
##########
@@ -2473,6 +2473,7 @@ export class Instance implements Disposable {
switch (tcode) {
case ArgTypeCode.Int:
case ArgTypeCode.UInt:
+ case ArgTypeCode.TVMArgBool:
return this.memory.loadI64(rvaluePtr);
Review Comment:
cc @tqchen, would `loadI64()` be the right function to use for bool?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Web] Add TVMArgBool to ArgTypeCode [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17251:
URL: https://github.com/apache/tvm/pull/17251#issuecomment-2305264953
#17240 has now landed, so this PR should be able to be revisited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Web] Add TVMArgBool to ArgTypeCode [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #17251:
URL: https://github.com/apache/tvm/pull/17251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org