You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/11/29 22:35:52 UTC
Review Request 54179: Updated master to use BoundedHashMap.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54179/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
This replaces a few instances where boost::circular_buffer was
previously used.
Diffs
-----
src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f
src/master/master.hpp b6c610b79aab146ece6b9be59be86f283d1c9ee8
src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
Diff: https://reviews.apache.org/r/54179/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 54179: Updated master to use BoundedHashMap.
Posted by Neil Conway <ne...@gmail.com>.
> On Nov. 30, 2016, 3:18 p.m., Neil Conway wrote:
> > src/master/master.hpp, line 2589
> > <https://reviews.apache.org/r/54179/diff/1/?file=1572516#file1572516line2589>
> >
> > On reflection, this does change behavior slightly: previously, `completedTasks` could contain multiple completed tasks with the same task ID (this is not illegal because frameworks are allowed to reuse task IDs after the task has reached a terminal state). Using a `BoundedHashMap` means we'll store at most a single completed task with a given ID. Do we want to preserve the previous behavior?
This has been reverted. See also MESOS-6779.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54179/#review157412
-----------------------------------------------------------
On Dec. 12, 2016, 7:03 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54179/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 7:03 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This replaces a few instances where boost::circular_buffer was
> previously used.
>
>
> Diffs
> -----
>
> src/master/http.cpp d52806dcf8e4d64ebb98e191a01408c0fcae17ac
> src/master/master.hpp c304e69af0b7a720ea8277088cabc0675eec8b57
> src/master/master.cpp 8c1c7f94102a2f40fbdffaa36f2d1c15e78a906d
>
> Diff: https://reviews.apache.org/r/54179/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 54179: Updated master to use BoundedHashMap.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54179/#review157412
-----------------------------------------------------------
src/master/master.hpp (line 2587)
<https://reviews.apache.org/r/54179/#comment228011>
On reflection, this does change behavior slightly: previously, `completedTasks` could contain multiple completed tasks with the same task ID (this is not illegal because frameworks are allowed to reuse task IDs after the task has reached a terminal state). Using a `BoundedHashMap` means we'll store at most a single completed task with a given ID. Do we want to preserve the previous behavior?
- Neil Conway
On Nov. 29, 2016, 10:35 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54179/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 10:35 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This replaces a few instances where boost::circular_buffer was
> previously used.
>
>
> Diffs
> -----
>
> src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f
> src/master/master.hpp b6c610b79aab146ece6b9be59be86f283d1c9ee8
> src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
>
> Diff: https://reviews.apache.org/r/54179/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 54179: Updated master to use BoundedHashMap.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54179/
-----------------------------------------------------------
(Updated Dec. 12, 2016, 7:03 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Revert back to using circular_buffer to track completed tasks, per discussion.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
This replaces a few instances where boost::circular_buffer was
previously used.
Diffs (updated)
-----
src/master/http.cpp d52806dcf8e4d64ebb98e191a01408c0fcae17ac
src/master/master.hpp c304e69af0b7a720ea8277088cabc0675eec8b57
src/master/master.cpp 8c1c7f94102a2f40fbdffaa36f2d1c15e78a906d
Diff: https://reviews.apache.org/r/54179/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 54179: Updated master to use BoundedHashMap.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54179/#review158607
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Dec. 1, 2016, 10:34 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54179/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 10:34 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This replaces a few instances where boost::circular_buffer was
> previously used.
>
>
> Diffs
> -----
>
> src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f
> src/master/master.hpp 877ca9010d0d6efc97f3d71fbd27272a255409d0
> src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
>
> Diff: https://reviews.apache.org/r/54179/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 54179: Updated master to use BoundedHashMap.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54179/
-----------------------------------------------------------
(Updated Dec. 1, 2016, 10:34 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Tweak comment.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
This replaces a few instances where boost::circular_buffer was
previously used.
Diffs (updated)
-----
src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f
src/master/master.hpp 877ca9010d0d6efc97f3d71fbd27272a255409d0
src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
Diff: https://reviews.apache.org/r/54179/diff/
Testing
-------
`make check`
Thanks,
Neil Conway