You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/21 15:18:13 UTC

[GitHub] [lucene] mocobeta opened a new pull request #757: LUCENE-10478: mark Test4GBStoredFields as @Monster

mocobeta opened a new pull request #757:
URL: https://github.com/apache/lucene/pull/757


   Excludes `Test4GBStoredFields` from nightly tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] mocobeta merged pull request #757: LUCENE-10478: mark Test4GBStoredFields as @Monster

Posted by GitBox <gi...@apache.org>.
mocobeta merged pull request #757:
URL: https://github.com/apache/lucene/pull/757


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] mocobeta commented on a change in pull request #757: LUCENE-10478: mark Test4GBStoredFields as @Monster

Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #757:
URL: https://github.com/apache/lucene/pull/757#discussion_r831910208



##########
File path: lucene/core/src/test/org/apache/lucene/index/Test4GBStoredFields.java
##########
@@ -26,13 +26,15 @@
 import org.apache.lucene.tests.codecs.compressing.CompressingCodec;
 import org.apache.lucene.tests.store.MockDirectoryWrapper;
 import org.apache.lucene.tests.util.LuceneTestCase;
+import org.apache.lucene.tests.util.LuceneTestCase.Monster;
 import org.apache.lucene.tests.util.LuceneTestCase.SuppressCodecs;
 import org.apache.lucene.tests.util.TimeUnits;
 import org.apache.lucene.util.BytesRef;
 
 /** This test creates an index with one segment that is a little larger than 4GB. */
 @SuppressCodecs({"SimpleText", "Compressing"})
 @TimeoutSuite(millis = 4 * TimeUnits.HOUR)
+@Monster("consumes a lot of disk space")
 public class Test4GBStoredFields extends LuceneTestCase {
 
   @Nightly

Review comment:
       Sure, removed at https://github.com/apache/lucene/pull/757/commits/8fc5baa95cda96d4d44cbfdc74db54bedb8cb790




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] mocobeta commented on pull request #757: LUCENE-10478: mark Test4GBStoredFields as @Monster

Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #757:
URL: https://github.com/apache/lucene/pull/757#issuecomment-1074038814


   It seems the commit message accidentally mentions an unrelated github account - I'm sorry for the noise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jpountz commented on a change in pull request #757: LUCENE-10478: mark Test4GBStoredFields as @Monster

Posted by GitBox <gi...@apache.org>.
jpountz commented on a change in pull request #757:
URL: https://github.com/apache/lucene/pull/757#discussion_r831260485



##########
File path: lucene/core/src/test/org/apache/lucene/index/Test4GBStoredFields.java
##########
@@ -26,13 +26,15 @@
 import org.apache.lucene.tests.codecs.compressing.CompressingCodec;
 import org.apache.lucene.tests.store.MockDirectoryWrapper;
 import org.apache.lucene.tests.util.LuceneTestCase;
+import org.apache.lucene.tests.util.LuceneTestCase.Monster;
 import org.apache.lucene.tests.util.LuceneTestCase.SuppressCodecs;
 import org.apache.lucene.tests.util.TimeUnits;
 import org.apache.lucene.util.BytesRef;
 
 /** This test creates an index with one segment that is a little larger than 4GB. */
 @SuppressCodecs({"SimpleText", "Compressing"})
 @TimeoutSuite(millis = 4 * TimeUnits.HOUR)
+@Monster("consumes a lot of disk space")
 public class Test4GBStoredFields extends LuceneTestCase {
 
   @Nightly

Review comment:
       let's remove the nightly annotation now that this class is annotated as a monster?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org