You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Yao Zhang <ya...@gmail.com> on 2012/03/01 07:29:05 UTC
Re: Review Request: rpc does not support communicating with gadget created
on an dom node in existing iframe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3908/
-----------------------------------------------------------
(Updated 2012-03-01 06:29:05.314946)
Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton Sievers.
Summary
-------
When you try to render a gadget to a dom node inside an existing iframe, rpc does not work as the code is using document.getElementById to get the domnode
This addresses bug SHINDIG-1704.
https://issues.apache.org/jira/browse/SHINDIG-1704
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1238149
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js 1291547
Diff: https://reviews.apache.org/r/3908/diff
Testing
-------
Thanks,
Yao
Re: Review Request: rpc does not support communicating with gadget created
on an dom node in existing iframe
Posted by Stanton Sievers <si...@gmail.com>.
> On March 1, 2012, 7:04 p.m., Henry Saputra wrote:
> > I think the scenario is not what the rpc mechanism intend to do. The communication between container and gadgets happen between one parent window and a child window via iframe.
>
> Yao Zhang wrote:
> Hi Henry,
> There is the scenario that people want to render their gadget inside an existing iframe(like inside a editor). And rcp prevent them do so... Do you think this is a reasonable scenario?
Henry, in the past I've had conversations with Fargo about the flexibility of RPC and certain assumptions it makes around where elements live. He made it sound like the current RPC implementation *was* inflexible and really needed an overhaul. In lieu of a complete overhaul (maybe in the 3.0) timeframe, I think this patch gets us part of the way there and helps with a subset of use cases.
- Stanton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3908/#review5510
-----------------------------------------------------------
On March 19, 2012, 7:38 a.m., Yao Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3908/
> -----------------------------------------------------------
>
> (Updated March 19, 2012, 7:38 a.m.)
>
>
> Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> When you try to render a gadget to a dom node inside an existing iframe, rpc does not work as the code is using document.getElementById to get the domnode
>
>
> This addresses bug SHINDIG-1704.
> https://issues.apache.org/jira/browse/SHINDIG-1704
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1299960
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1299960
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js 1299960
>
> Diff: https://reviews.apache.org/r/3908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yao Zhang
>
>
Re: Review Request: rpc does not support communicating with gadget created
on an dom node in existing iframe
Posted by Yao Zhang <ya...@gmail.com>.
> On 2012-03-01 19:04:07, Henry Saputra wrote:
> > I think the scenario is not what the rpc mechanism intend to do. The communication between container and gadgets happen between one parent window and a child window via iframe.
Hi Henry,
There is the scenario that people want to render their gadget inside an existing iframe(like inside a editor). And rcp prevent them do so... Do you think this is a reasonable scenario?
- Yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3908/#review5510
-----------------------------------------------------------
On 2012-03-01 06:29:05, Yao Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3908/
> -----------------------------------------------------------
>
> (Updated 2012-03-01 06:29:05)
>
>
> Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton Sievers.
>
>
> Summary
> -------
>
> When you try to render a gadget to a dom node inside an existing iframe, rpc does not work as the code is using document.getElementById to get the domnode
>
>
> This addresses bug SHINDIG-1704.
> https://issues.apache.org/jira/browse/SHINDIG-1704
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1238149
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js 1291547
>
> Diff: https://reviews.apache.org/r/3908/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yao
>
>
Re: Review Request: rpc does not support communicating with gadget created
on an dom node in existing iframe
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3908/#review5510
-----------------------------------------------------------
I think the scenario is not what the rpc mechanism intend to do. The communication between container and gadgets happen between one parent window and a child window via iframe.
- Henry
On 2012-03-01 06:29:05, Yao Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3908/
> -----------------------------------------------------------
>
> (Updated 2012-03-01 06:29:05)
>
>
> Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton Sievers.
>
>
> Summary
> -------
>
> When you try to render a gadget to a dom node inside an existing iframe, rpc does not work as the code is using document.getElementById to get the domnode
>
>
> This addresses bug SHINDIG-1704.
> https://issues.apache.org/jira/browse/SHINDIG-1704
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1238149
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js 1291547
>
> Diff: https://reviews.apache.org/r/3908/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yao
>
>
Re: Review Request: rpc does not support communicating with gadget created
on an dom node in existing iframe
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3908/#review8754
-----------------------------------------------------------
To make it easier to review, please format the patch following the Apache Shindig recommended JavaScript formatting: https://cwiki.apache.org/SHINDIGxSITE/javascript-style.html
- Henry Saputra
On March 19, 2012, 7:38 a.m., Yao Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3908/
> -----------------------------------------------------------
>
> (Updated March 19, 2012, 7:38 a.m.)
>
>
> Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> When you try to render a gadget to a dom node inside an existing iframe, rpc does not work as the code is using document.getElementById to get the domnode
>
>
> This addresses bug SHINDIG-1704.
> https://issues.apache.org/jira/browse/SHINDIG-1704
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1299960
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1299960
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js 1299960
>
> Diff: https://reviews.apache.org/r/3908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yao Zhang
>
>
Re: Review Request: rpc does not support communicating with gadget created
on an dom node in existing iframe
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3908/#review8743
-----------------------------------------------------------
Can you look at adding some JUnits around this functionality? I'm always concerned about breaking RPC, since it is at the core of basically everything that happens client-side.
The rest is mostly comments on style.
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js
<https://reviews.apache.org/r/3908/#comment18441>
Nit on whitespace and use of tabs instead of spaces.
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js
<https://reviews.apache.org/r/3908/#comment18442>
Nite on trailing whitespace
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
<https://reviews.apache.org/r/3908/#comment18443>
Nit on tabs instead of spaces
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
<https://reviews.apache.org/r/3908/#comment18444>
Nit on whitespace
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
<https://reviews.apache.org/r/3908/#comment18445>
Nit on tabs instead of spaces
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
<https://reviews.apache.org/r/3908/#comment18446>
Nit on tabs instead of spaces.
- Stanton Sievers
On March 19, 2012, 7:38 a.m., Yao Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3908/
> -----------------------------------------------------------
>
> (Updated March 19, 2012, 7:38 a.m.)
>
>
> Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> When you try to render a gadget to a dom node inside an existing iframe, rpc does not work as the code is using document.getElementById to get the domnode
>
>
> This addresses bug SHINDIG-1704.
> https://issues.apache.org/jira/browse/SHINDIG-1704
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1299960
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1299960
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js 1299960
>
> Diff: https://reviews.apache.org/r/3908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yao Zhang
>
>
Re: Review Request: rpc does not support communicating with gadget created
on an dom node in existing iframe
Posted by Yao Zhang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3908/
-----------------------------------------------------------
(Updated 2012-03-19 07:38:42.936953)
Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton Sievers.
Summary
-------
When you try to render a gadget to a dom node inside an existing iframe, rpc does not work as the code is using document.getElementById to get the domnode
This addresses bug SHINDIG-1704.
https://issues.apache.org/jira/browse/SHINDIG-1704
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1299960
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1299960
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js 1299960
Diff: https://reviews.apache.org/r/3908/diff
Testing
-------
Thanks,
Yao