You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Gary Dusbabek (JIRA)" <ji...@apache.org> on 2010/03/17 20:41:27 UTC

[jira] Created: (CASSANDRA-902) Bootstrapping might skip needed ranges.

Bootstrapping might skip needed ranges.
---------------------------------------

                 Key: CASSANDRA-902
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-902
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 0.6
            Reporter: Gary Dusbabek
            Assignee: Gary Dusbabek
             Fix For: 0.6


Bootstrapper.getRangeWithSources should return a multimap with as many keys as myRangeAddresses.  But with the way the two loops are structured, they are not guaranteed to ever examine all of myRanges.  To see why, consider a scenario where the inner-loop breaks on the first element in myRanges.  myRangeAddresses will only ever have one key in it.

Solution is to swap the order of the loops.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-902) Bootstrapping might skip needed ranges.

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-902:
------------------------------------

    Attachment: bootstrap-range-addr-calculation.txt

patched against trunk.  The same code exists in 5, so is likely a problem there too.

> Bootstrapping might skip needed ranges.
> ---------------------------------------
>
>                 Key: CASSANDRA-902
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-902
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.6
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.6
>
>         Attachments: bootstrap-range-addr-calculation.txt
>
>
> Bootstrapper.getRangeWithSources should return a multimap with as many keys as myRangeAddresses.  But with the way the two loops are structured, they are not guaranteed to ever examine all of myRanges.  To see why, consider a scenario where the inner-loop breaks on the first element in myRanges.  myRangeAddresses will only ever have one key in it.
> Solution is to swap the order of the loops.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-902) Bootstrapping might skip needed ranges.

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846570#action_12846570 ] 

Jonathan Ellis commented on CASSANDRA-902:
------------------------------------------

+1 0.6 and trunk

> Bootstrapping might skip needed ranges.
> ---------------------------------------
>
>                 Key: CASSANDRA-902
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-902
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.6
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.6
>
>         Attachments: bootstrap-range-addr-calculation.txt
>
>
> Bootstrapper.getRangeWithSources should return a multimap with as many keys as myRangeAddresses.  But with the way the two loops are structured, they are not guaranteed to ever examine all of myRanges.  To see why, consider a scenario where the inner-loop breaks on the first element in myRanges.  myRangeAddresses will only ever have one key in it.
> Solution is to swap the order of the loops.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.