You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2022/07/06 23:58:26 UTC
[GitHub] [tomee] bdemers opened a new pull request, #900: Update exception message for MDB without an interface
bdemers opened a new pull request, #900:
URL: https://github.com/apache/tomee/pull/900
I don't actually know what a `MDB` is, after a quick google i'm guessing it a `MessageDriven` bean". Either way, the error message should spell it out.
> **NOTE:** I updated this through GitHub's web view, if CI fails, and this change is _valid_ I'll try to fix the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] bdemers commented on pull request #900: Update exception message for MDB without an interface
Posted by GitBox <gi...@apache.org>.
bdemers commented on PR #900:
URL: https://github.com/apache/tomee/pull/900#issuecomment-1177762822
It looks like the Jenkins build error might be unrelated to this change?
> [ERROR] WARNING: An illegal reflective access operation has occurred
If you think it is related to this change, let me know and I can try to poke around a little more 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #900: Update exception message for MDB without an interface
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #900:
URL: https://github.com/apache/tomee/pull/900#issuecomment-1177851461
> It looks like the Jenkins build error might be unrelated to this change?
>
> > [ERROR] WARNING: An illegal reflective access operation has occurred
>
> If you think it is related to this change, let me know and I can try to poke around a little more smile
The Jenkins build for pull request is a bit unreliable. So bascially it is not related ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] bdemers commented on a diff in pull request #900: Update exception message for MDB without an interface
Posted by GitBox <gi...@apache.org>.
bdemers commented on code in PR #900:
URL: https://github.com/apache/tomee/pull/900#discussion_r915340377
##########
container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiEjbBean.java:
##########
@@ -250,7 +250,7 @@ protected T createEjb(final CreationalContext<T> creationalContext) {
} else if (remote != null) {
instance = (T) remote.create();
} else { // shouldn't be called for an MDB
- throw new IllegalStateException("no interface to proxy for ejb " + beanContext.getEjbName() + ", is this is a MDB maybe you shouldn't use a scope?");
+ throw new IllegalStateException("no interface to proxy for ejb " + beanContext.getEjbName() + ", is this is a @MessageDriven bean, maybe you shouldn't use a scope?");
Review Comment:
In my case, it's not a message-driven bean, but I like the suggestion, maybe the wording should be something like:
```suggestion
throw new IllegalStateException("No interface to proxy for ejb " + beanContext.getEjbName() + ", if this is a @MessageDriven bean, try not using a scope?");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on a diff in pull request #900: Update exception message for MDB without an interface
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #900:
URL: https://github.com/apache/tomee/pull/900#discussion_r915541833
##########
container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiEjbBean.java:
##########
@@ -250,7 +250,7 @@ protected T createEjb(final CreationalContext<T> creationalContext) {
} else if (remote != null) {
instance = (T) remote.create();
} else { // shouldn't be called for an MDB
- throw new IllegalStateException("no interface to proxy for ejb " + beanContext.getEjbName() + ", is this is a MDB maybe you shouldn't use a scope?");
+ throw new IllegalStateException("no interface to proxy for ejb " + beanContext.getEjbName() + ", is this is a @MessageDriven bean, maybe you shouldn't use a scope?");
Review Comment:
Thanks @bdemers - you are right. MDB means `@MessageDriven` bean here. I think that the proposed change is valid and clarifies the error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 merged pull request #900: Update exception message for MDB without an interface
Posted by GitBox <gi...@apache.org>.
rzo1 merged PR #900:
URL: https://github.com/apache/tomee/pull/900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org