You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/08 13:55:43 UTC
[GitHub] [zookeeper] amichair opened a new pull request #1598: ZOOKEEPER-4204: Remove unnecessary creation of thousands of thread in…
amichair opened a new pull request #1598:
URL: https://github.com/apache/zookeeper/pull/1598
…stances to prevent RequestPathMetricsCollectorTest.testMultiThreadPerf occasional failures
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg closed pull request #1598: ZOOKEEPER-4204: Remove unnecessary creation of thousands of thread in…
Posted by GitBox <gi...@apache.org>.
ztzg closed pull request #1598:
URL: https://github.com/apache/zookeeper/pull/1598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] amichair commented on pull request #1598: ZOOKEEPER-4204: Remove unnecessary creation of thousands of thread in…
Posted by GitBox <gi...@apache.org>.
amichair commented on pull request #1598:
URL: https://github.com/apache/zookeeper/pull/1598#issuecomment-775185515
CI error looks like an unrelated typo in another test ("direcory").
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] amichair commented on pull request #1598: ZOOKEEPER-4204: Remove unnecessary creation of thousands of thread in…
Posted by GitBox <gi...@apache.org>.
amichair commented on pull request #1598:
URL: https://github.com/apache/zookeeper/pull/1598#issuecomment-781575161
I wrote a little more in the ZOOKEEPER-4204 issue. At least in my case on one machine, it went from failing several times in a row to not failing several times in a row (on another machine it never failed in the first place). I was also a bit surprised, but I guess there's enough bookkeeping being done (a Thread is not just a POJO with an empty constructor), times tens of thousands of instances, that it made a difference. Failures were about timings, so anything that wastes time overhead on the test itself increases the chance of failure. As I wrote there, I'm not sure it will be solved in all scenarios, but it seems to be a good first step, and is certainly a correct correction in any case...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] amichair commented on pull request #1598: ZOOKEEPER-4204: Remove unnecessary creation of thousands of thread in…
Posted by GitBox <gi...@apache.org>.
amichair commented on pull request #1598:
URL: https://github.com/apache/zookeeper/pull/1598#issuecomment-814044202
Will you merge it if I remove ZOOKEEPER-4204 from the title? Whether or not it completely solves the issue (probably not), it's an improvement and does alleviate the issue on some machines like mine...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1598: ZOOKEEPER-4204: Remove unnecessary creation of thousands of thread in…
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1598:
URL: https://github.com/apache/zookeeper/pull/1598#issuecomment-888313535
Hi @amichair,
Thank you for this fix. I have merged it in `master` and `branch-3.7`. A new ticket can be open if we observe more issues with that specific test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org