You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/07/18 09:05:07 UTC

[GitHub] [netbeans] matthiasblaesing opened a new pull request #3061: Use j.u.Properties instead of o.o.u.EditableProperties to reduce CPU usage

matthiasblaesing opened a new pull request #3061:
URL: https://github.com/apache/netbeans/pull/3061


   It was observed, that with a big project, massive time was spend in 
   org.openide.util.EditableProperties.addItem(). Given, that none of the
   benefits of EditableProperties take hold:
   
   - the properties are used as pure backing store, without the expectation
     of a user to modify them
   - the order of the entries is irrelevant
   - the file is not put into VCS (it is in the cache path)
   - special line break handling is not relevant
   
   the easiest work around is to drop usage of EditableProperties and
   use plain Properties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #3061: Use j.u.Properties instead of o.o.u.EditableProperties to reduce CPU usage

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3061:
URL: https://github.com/apache/netbeans/pull/3061#issuecomment-882102158


   @jlahoda thank you for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing merged pull request #3061: Use j.u.Properties instead of o.o.u.EditableProperties to reduce CPU usage

Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #3061:
URL: https://github.com/apache/netbeans/pull/3061


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] jlahoda commented on pull request #3061: Use j.u.Properties instead of o.o.u.EditableProperties to reduce CPU usage

Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #3061:
URL: https://github.com/apache/netbeans/pull/3061#issuecomment-882057102


   @matthiasblaesing, sorry for trouble. Using `Properties` looks fine. It would also probably be enough to use `EditableProperties(false)` to avoid sorting (not sure why I used `true` anyway - probably no particular good reason).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #3061: Use j.u.Properties instead of o.o.u.EditableProperties to reduce CPU usage

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3061:
URL: https://github.com/apache/netbeans/pull/3061#issuecomment-882025891


   @jlahoda could you please have a look at this? The project I observed the massive times in showed a property list with > 70.000 entries and the sampling profiler from visual vm led me directly to the addItem method of EditableProperties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists