You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "wg1026688210 (via GitHub)" <gi...@apache.org> on 2023/07/02 12:53:17 UTC

[GitHub] [incubator-paimon] wg1026688210 commented on a diff in pull request #1425: [core] add default column value

wg1026688210 commented on code in PR #1425:
URL: https://github.com/apache/incubator-paimon/pull/1425#discussion_r1249501820


##########
paimon-core/src/main/java/org/apache/paimon/stats/FieldStatsArraySerializer.java:
##########
@@ -65,6 +77,7 @@ public FieldStatsArraySerializer(
                         .toArray(InternalRow.FieldGetter[]::new);
         this.indexMapping = indexMapping;
         this.converterMapping = converterMapping;
+        this.skipFieldIndex = skipFieldIndex;

Review Comment:
   Can we use skipStatField instead? This might be more generic in FieldStatsArraySerializer ,FieldStatsArraySerializer  may don't need care the default vale concept  of table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org