[GitHub] [pulsar] merlimat commented on a change in pull request #9893: More fixes about running tests on JDK11

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #9893:
URL: https://github.com/apache/pulsar/pull/9893#discussion_r593342013



##########
File path: pom.xml
##########
@@ -209,6 +209,7 @@ flexible messaging model and an intuitive client API.</description>
     <directory-maven-plugin.version>0.3.1</directory-maven-plugin.version>
     <maven-enforcer-plugin.version>3.0.0-M2</maven-enforcer-plugin.version>
     <maven-surefire-plugin.version>3.0.0-M3</maven-surefire-plugin.version>
+    <test.additional.args></test.additional.args>

Review comment:
       Nit: maybe this variable could be moved to the top of the sections instead of being grouped with the version variables.

##########
File path: pom.xml
##########
@@ -143,8 +143,8 @@ flexible messaging model and an intuitive client API.</description>
     <postgresql-jdbc.version>42.2.12</postgresql-jdbc.version>
     <clickhouse-jdbc.version>0.2.4</clickhouse-jdbc.version>
     <mariadb-jdbc.version>2.6.0</mariadb-jdbc.version>
-    <hdfs-offload-version3>3.2.0</hdfs-offload-version3>
-    <org.eclipse.jetty-hdfs-offload>9.3.24.v20180605</org.eclipse.jetty-hdfs-offload>
+    <hdfs-offload-version3>3.3.0</hdfs-offload-version3>
+    <org.eclipse.jetty-hdfs-offload>${jetty.version}</org.eclipse.jetty-hdfs-offload>

Review comment:
       Could we just remove the special variable and use `${jetty.version}` directly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org