[GitHub] [nifi] mattyb149 commented on a change in pull request #4436: NIFI-7680 Added convenience methods for creating XML DocumentBuilder …

[GitBox <gi...@apache.org>]

mattyb149 commented on a change in pull request #4436:
URL: https://github.com/apache/nifi/pull/4436#discussion_r461745355



##########
File path: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java
##########
@@ -27,7 +44,9 @@
 import org.apache.nifi.components.PropertyValue;
 import org.apache.nifi.components.ValidationContext;
 import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.parameter.ParameterLookup;
 import org.apache.nifi.registry.VariableRegistry;
+import org.apache.nifi.security.xml.XmlUtils;

Review comment:
       Now that nifi-bootstrap depends on nifi-security-utils, we'll have to make sure it's in the `lib/bootstrap/` directory in the assembly:
   
   nifi-assembly/src/main/assembly/common.xml line 31 insert:
   `<include>nifi-security-utils</include>`

##########
File path: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java
##########
@@ -27,7 +44,9 @@
 import org.apache.nifi.components.PropertyValue;
 import org.apache.nifi.components.ValidationContext;
 import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.parameter.ParameterLookup;
 import org.apache.nifi.registry.VariableRegistry;
+import org.apache.nifi.security.xml.XmlUtils;

Review comment:
       Looks like there's a better solution by just making it available via nifi-framework-authorization, will try with the latest




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org