You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alinaliBQ (via GitHub)" <gi...@apache.org> on 2026/05/04 18:12:03 UTC

Re: [PR] GH-47876: [C++][FlightRPC] ODBC: macOS `.PKG` installer for Intel and ARM [arrow]

alinaliBQ commented on code in PR #49766:
URL: https://github.com/apache/arrow/pull/49766#discussion_r3183527943


##########
cpp/src/arrow/flight/sql/odbc/CMakeLists.txt:
##########
@@ -159,6 +158,66 @@ if(ARROW_FLIGHT_SQL_ODBC_INSTALLER)
 
     set(CPACK_WIX_UI_BANNER
         "${CMAKE_CURRENT_SOURCE_DIR}/install/windows/arrow-wix-banner.bmp")
+  else()
+    if(APPLE)
+      set(CPACK_PACKAGE_FILE_NAME
+          "ArrowFlightSqlOdbc-${CPACK_PACKAGE_VERSION_MAJOR}.${ODBC_PACKAGE_VERSION_MINOR}.${ODBC_PACKAGE_VERSION_PATCH}"

Review Comment:
   @justing-bq we can change `CPACK_PACKAGE_FILE_NAME` to `SQLODBC` since it is for installer file name, it is not an internal variable here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org