You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/26 12:21:37 UTC
[GitHub] [flink] leonardBang opened a new pull request #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
leonardBang opened a new pull request #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700
Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*This pull request fix sink schema field name was used in UpsertStreamTableSink instead of query schema field name in blink planner and legacy planner.*
## Brief change log
- *legacy planner: fix StreamPlanner and UpdatingPlanChecker*
- *blink planner: fix StreamExecSink and UpdatingPlanChecker*
## Verifying this change
- * add IT case in TableSinkITCase for legacy planner and blink planner*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142646604 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142646604) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988)
* f54bb5b85d434c034686114b3b50655c062b340a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142646604 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142648987 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142727386 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
Hash:6984fe71af335b265abaaae3fa524be760e02563 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142843379 TriggerType:PUSH TriggerID:6984fe71af335b265abaaae3fa524be760e02563
Hash:6984fe71af335b265abaaae3fa524be760e02563 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4036 TriggerType:PUSH TriggerID:6984fe71af335b265abaaae3fa524be760e02563
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142646604) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988)
* f54bb5b85d434c034686114b3b50655c062b340a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142648987) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989)
* 8cf3dd6ab802dcf2717c7495b41fa52861e39dae Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142727386) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006)
* 6984fe71af335b265abaaae3fa524be760e02563 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142843379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4036)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142646604 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142648987 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142727386 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
Hash:6984fe71af335b265abaaae3fa524be760e02563 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142843379 TriggerType:PUSH TriggerID:6984fe71af335b265abaaae3fa524be760e02563
Hash:6984fe71af335b265abaaae3fa524be760e02563 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4036 TriggerType:PUSH TriggerID:6984fe71af335b265abaaae3fa524be760e02563
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142646604) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988)
* f54bb5b85d434c034686114b3b50655c062b340a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142648987) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989)
* 8cf3dd6ab802dcf2717c7495b41fa52861e39dae Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142727386) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006)
* 6984fe71af335b265abaaae3fa524be760e02563 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142843379) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4036)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10700: [FLINK-15383][table sql
/ planner & legacy planner] Using sink schema field name instead of query
schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569049904
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4e596c6982db0ff2416530e688d7f6d45329f465 (Thu Dec 26 12:24:37 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142646604 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142648987 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142646604) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988)
* f54bb5b85d434c034686114b3b50655c062b340a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142648987) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#discussion_r361933376
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/util/UpdatingPlanChecker.scala
##########
@@ -37,8 +37,12 @@ object UpdatingPlanChecker {
}
/** Extracts the unique keys of the table produced by the plan. */
- def getUniqueKeyFields(plan: RelNode): Option[Array[String]] = {
- getUniqueKeyGroups(plan).map(_.map(_._1).toArray)
+ def getUniqueKeyFields(plan: RelNode, sinkFieldNames: List[String]): Option[Array[String]] = {
+ val relFieldNames = plan.getRowType.getFieldNames
+ getUniqueKeyGroups(plan).map(
+ _.map(
+ r => sinkFieldNames.get(relFieldNames.indexOf(r._1))
Review comment:
Don't need new line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142646604 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142648987 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142646604) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988)
* f54bb5b85d434c034686114b3b50655c062b340a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142648987) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142646604 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142648987 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142727386 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142646604) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988)
* f54bb5b85d434c034686114b3b50655c062b340a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142648987) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989)
* 8cf3dd6ab802dcf2717c7495b41fa52861e39dae Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142727386) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142646604 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142648987 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142727386 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142646604) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988)
* f54bb5b85d434c034686114b3b50655c062b340a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142648987) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989)
* 8cf3dd6ab802dcf2717c7495b41fa52861e39dae Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142727386) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang commented on issue #10700: [FLINK-15383][table
sql / planner & legacy planner] Using sink schema field name instead of
query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-570131309
@wuchong Could you have a more look? thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#discussion_r361889801
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/UpdatingPlanChecker.scala
##########
@@ -38,12 +37,14 @@ object UpdatingPlanChecker {
}
/** Extracts the unique keys of the table produced by the plan. */
- def getUniqueKeyFields(relNode: RelNode, planner: StreamPlanner): Option[Array[Array[String]]] = {
- val rowType = relNode.getRowType
+ def getUniqueKeyFields(
+ relNode: RelNode,
+ planner: StreamPlanner,
+ sinkFieldNames: List[String]): Option[Array[Array[String]]] = {
Review comment:
`sinkFieldNames: Array[String]`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#discussion_r361941184
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/UpdatingPlanChecker.scala
##########
@@ -20,7 +20,6 @@ package org.apache.flink.table.planner.plan.utils
import org.apache.flink.table.planner.delegation.StreamPlanner
import org.apache.flink.table.planner.plan.metadata.FlinkRelMetadataQuery
import org.apache.flink.table.planner.plan.nodes.physical.stream._
-
Review comment:
Please keep this empty line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#discussion_r361933095
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/util/UpdatingPlanChecker.scala
##########
@@ -37,8 +37,12 @@ object UpdatingPlanChecker {
}
/** Extracts the unique keys of the table produced by the plan. */
- def getUniqueKeyFields(plan: RelNode): Option[Array[String]] = {
- getUniqueKeyGroups(plan).map(_.map(_._1).toArray)
+ def getUniqueKeyFields(plan: RelNode, sinkFieldNames: List[String]): Option[Array[String]] = {
Review comment:
Use array not use `List` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi removed a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
JingsongLi removed a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569568409
Is this for FLINK-15383?
"Using sink Schema field name instead of query Schema field name in UpsertStreamTableSink"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10700: [FLINK-15383][table
sql / planner & legacy planner] Using sink schema field name instead of
query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569568409
Is this for FLINK-15383?
"Using sink Schema field name instead of query Schema field name in UpsertStreamTableSink"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang commented on issue #10700: [FLINK-15383][table
sql / planner & legacy planner] Using sink schema field name instead of
query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-570195441
@wuchong @JingsongLi Thanks very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10700: [FLINK-15383][table
sql / planner & legacy planner] Using sink schema field name instead of
query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-570152404
LGTM thanks @wuchong and @leonardBang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10700: [FLINK-15383][table sql
/ planner & legacy planner] Using sink schema field name instead of query
schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on issue #10700: [FLINK-15383][table sql
/ planner & legacy planner] Using sink schema field name instead of query
schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-570136912
Waiting for travis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#discussion_r361942857
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/table/TableSinkITCase.scala
##########
@@ -312,9 +312,10 @@ class TableSinkITCase extends AbstractTestBase {
t.select('id, 'num, 'text.charLength() as 'len, ('id > 0) as 'cTrue)
.groupBy('len, 'cTrue)
- .select('len, 'id.count as 'cnt, 'cTrue)
- .groupBy('cnt, 'cTrue)
- .select('cnt, 'len.count as 'lencnt, 'cTrue)
+ // test query field name is different with registered sink field name
+ .select('len, 'id.count as 'count, 'cTrue)
+ .groupBy('count, 'cTrue)
+ .select('count, 'len.count as 'lencnt, 'cTrue)
Review comment:
This case doesn't reproduce the problem. You should also update `TestingUpsertTableSink#expectedKeys` to make sure `setKeyFields()` will verify the mapping between keys parameter and schema fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#discussion_r361889745
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamExecSink.scala
##########
@@ -101,7 +101,9 @@ class StreamExecSink[T](
// Now we pick shortest one to sink
// TODO UpsertStreamTableSink setKeyFields interface should be Array[Array[String]]
val tableKeys = {
- UpdatingPlanChecker.getUniqueKeyFields(getInput, planner) match {
+ val sinkFieldNames = upsertSink.getTableSchema.getFieldNames.toList
+ UpdatingPlanChecker.getUniqueKeyFields(getInput, planner, sinkFieldNames)
+ match {
Review comment:
move `match {` to above line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142646604 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142648987 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142646604) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988)
* f54bb5b85d434c034686114b3b50655c062b340a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142648987) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989)
* 8cf3dd6ab802dcf2717c7495b41fa52861e39dae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10700: [FLINK-15383][table sql
/ planner & legacy planner] Using sink schema field name instead of query
schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang commented on issue #10700: [FLINK-15383][table
sql / planner & legacy planner] Using sink schema field name instead of
query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
leonardBang commented on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569577953
> Thanks @leonardBang , left some comments.
Thanks @JingsongLi, I'll update soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142646604 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142648987 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142727386 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
Hash:6984fe71af335b265abaaae3fa524be760e02563 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:6984fe71af335b265abaaae3fa524be760e02563
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142646604) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988)
* f54bb5b85d434c034686114b3b50655c062b340a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142648987) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989)
* 8cf3dd6ab802dcf2717c7495b41fa52861e39dae Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142727386) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006)
* 6984fe71af335b265abaaae3fa524be760e02563 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142644145 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986 TriggerType:PUSH TriggerID:9e65c9bd9f94a9741a8967f5ed7f8b926655dd26
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:721deb991f908eb91ba6dc0622584f1ea76d45dc Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142646604 TriggerType:PUSH TriggerID:721deb991f908eb91ba6dc0622584f1ea76d45dc
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142648987 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:f54bb5b85d434c034686114b3b50655c062b340a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989 TriggerType:PUSH TriggerID:f54bb5b85d434c034686114b3b50655c062b340a
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142727386 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
Hash:8cf3dd6ab802dcf2717c7495b41fa52861e39dae Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006 TriggerType:PUSH TriggerID:8cf3dd6ab802dcf2717c7495b41fa52861e39dae
Hash:6984fe71af335b265abaaae3fa524be760e02563 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142843379 TriggerType:PUSH TriggerID:6984fe71af335b265abaaae3fa524be760e02563
Hash:6984fe71af335b265abaaae3fa524be760e02563 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4036 TriggerType:PUSH TriggerID:6984fe71af335b265abaaae3fa524be760e02563
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
* 9e65c9bd9f94a9741a8967f5ed7f8b926655dd26 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142644145) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3986)
* 721deb991f908eb91ba6dc0622584f1ea76d45dc Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142646604) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3988)
* f54bb5b85d434c034686114b3b50655c062b340a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142648987) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3989)
* 8cf3dd6ab802dcf2717c7495b41fa52861e39dae Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142727386) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4006)
* 6984fe71af335b265abaaae3fa524be760e02563 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142843379) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4036)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#discussion_r361890572
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/table/TableSinkITCase.scala
##########
@@ -312,9 +312,9 @@ class TableSinkITCase extends AbstractTestBase {
t.select('id, 'num, 'text.charLength() as 'len, ('id > 0) as 'cTrue)
.groupBy('len, 'cTrue)
- .select('len, 'id.count as 'cnt, 'cTrue)
- .groupBy('cnt, 'cTrue)
- .select('cnt, 'len.count as 'lencnt, 'cTrue)
+ .select('len, 'id.count as 'count, 'cTrue)
+ .groupBy('count, 'cTrue)
Review comment:
Add comment to show what are you test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10700:
[FLINK-15383][table sql / planner & legacy planner] Using sink schema field
name instead of query schema field name for UpsertStreamTableSink.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10700: [FLINK-15383][table sql / planner & legacy planner] Using sink schema field name instead of query schema field name for UpsertStreamTableSink.
URL: https://github.com/apache/flink/pull/10700#issuecomment-569055468
<!--
Meta data
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:4e596c6982db0ff2416530e688d7f6d45329f465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142375475 TriggerType:PUSH TriggerID:4e596c6982db0ff2416530e688d7f6d45329f465
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
Hash:bbb633a82d437b51b1551d550dc05d3bafcecab0 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142614951 TriggerType:PUSH TriggerID:bbb633a82d437b51b1551d550dc05d3bafcecab0
-->
## CI report:
* 4e596c6982db0ff2416530e688d7f6d45329f465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142375475) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3938)
* bbb633a82d437b51b1551d550dc05d3bafcecab0 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142614951) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services