You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Ari Rabkin (JIRA)" <ji...@apache.org> on 2008/12/17 01:28:46 UTC
[jira] Created: (HADOOP-4892) File descriptor leak in Chukwa's
ExecPlugin
File descriptor leak in Chukwa's ExecPlugin
-------------------------------------------
Key: HADOOP-4892
URL: https://issues.apache.org/jira/browse/HADOOP-4892
Project: Hadoop Core
Issue Type: Bug
Components: contrib/chukwa
Reporter: Ari Rabkin
Assignee: Ari Rabkin
Attachments: chukwafiledescleak.patch
Chukwa's ExecPlugin doesn't properly close pipes after running a child process. For ExecPlugin, this is benign, since it runs in a separate process. For ExecAdaptor, this is catastrophic, since file descriptors leak.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4892) File descriptor leak in Chukwa's
ExecPlugin
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ari Rabkin updated HADOOP-4892:
-------------------------------
Attachment: chukwafiledescleak.patch
Patch for issue.
> File descriptor leak in Chukwa's ExecPlugin
> -------------------------------------------
>
> Key: HADOOP-4892
> URL: https://issues.apache.org/jira/browse/HADOOP-4892
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Attachments: chukwafiledescleak.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> Chukwa's ExecPlugin doesn't properly close pipes after running a child process. For ExecPlugin, this is benign, since it runs in a separate process. For ExecAdaptor, this is catastrophic, since file descriptors leak.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4892) File descriptor leak in Chukwa's
ExecPlugin
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ari Rabkin updated HADOOP-4892:
-------------------------------
Status: Patch Available (was: Open)
No test included; obvious way to test this is to run lots of subprocesses; if the system doesn't die, the patch worked.
But this would be a distinctly heavyweight test with unpleasant consequences if it failed. Further, it wouldn't be very reliable since there's no way of knowing what any particular system's file descriptor limit is.
> File descriptor leak in Chukwa's ExecPlugin
> -------------------------------------------
>
> Key: HADOOP-4892
> URL: https://issues.apache.org/jira/browse/HADOOP-4892
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Attachments: chukwafiledescleak.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> Chukwa's ExecPlugin doesn't properly close pipes after running a child process. For ExecPlugin, this is benign, since it runs in a separate process. For ExecAdaptor, this is catastrophic, since file descriptors leak.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4892) File descriptor leak in Chukwa's
ExecPlugin
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657841#action_12657841 ]
Eric Yang commented on HADOOP-4892:
-----------------------------------
Looks good. Important patch. +1
> File descriptor leak in Chukwa's ExecPlugin
> -------------------------------------------
>
> Key: HADOOP-4892
> URL: https://issues.apache.org/jira/browse/HADOOP-4892
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Attachments: chukwafiledescleak.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> Chukwa's ExecPlugin doesn't properly close pipes after running a child process. For ExecPlugin, this is benign, since it runs in a separate process. For ExecAdaptor, this is catastrophic, since file descriptors leak.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4892) File descriptor leak in Chukwa's
ExecPlugin
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4892:
------------------------------------
Release Note: (was: Fix resource leak in ExecAdaptor)
No release note for "just a bug."
> File descriptor leak in Chukwa's ExecPlugin
> -------------------------------------------
>
> Key: HADOOP-4892
> URL: https://issues.apache.org/jira/browse/HADOOP-4892
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Fix For: 0.20.0
>
> Attachments: chukwafiledescleak.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> Chukwa's ExecPlugin doesn't properly close pipes after running a child process. For ExecPlugin, this is benign, since it runs in a separate process. For ExecAdaptor, this is catastrophic, since file descriptors leak.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4892) File descriptor leak in Chukwa's
ExecPlugin
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4892:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I committed this. Thanks, Ari
> File descriptor leak in Chukwa's ExecPlugin
> -------------------------------------------
>
> Key: HADOOP-4892
> URL: https://issues.apache.org/jira/browse/HADOOP-4892
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Fix For: 0.20.0
>
> Attachments: chukwafiledescleak.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> Chukwa's ExecPlugin doesn't properly close pipes after running a child process. For ExecPlugin, this is benign, since it runs in a separate process. For ExecAdaptor, this is catastrophic, since file descriptors leak.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.