You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/10/29 22:01:17 UTC
Review Request 39770: Write a newline in ABORT().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39770/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-3708
https://issues.apache.org/jira/browse/MESOS-3708
Repository: mesos
Description
-------
Write a newline in ABORT() so that the ABORT message doesn't run
on into any output from abort(3) and the associated signal backtracing.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 2b003d26d6b6b65b1d7b1dd6396f808c35b53177
Diff: https://reviews.apache.org/r/39770/diff/
Testing
-------
make check and manual testing.
Thanks,
James Peach
Re: Review Request 39770: Write a newline in ABORT().
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39770/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 12:25 a.m.)
Review request for mesos.
Bugs: MESOS-3708
https://issues.apache.org/jira/browse/MESOS-3708
Repository: mesos
Description
-------
Write a newline in ABORT() so that the ABORT message doesn't run
on into any output from abort(3) and the associated signal backtracing.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 2b003d26d6b6b65b1d7b1dd6396f808c35b53177
Diff: https://reviews.apache.org/r/39770/diff/
Testing
-------
make check and manual testing.
Thanks,
James Peach
Re: Review Request 39770: Write a newline in ABORT().
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39770/#review104508
-----------------------------------------------------------
Code looks good, need to add people for this RR.
- Guangya Liu
On Oct. 29, 2015, 9:01 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39770/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 9:01 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3708
> https://issues.apache.org/jira/browse/MESOS-3708
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Write a newline in ABORT() so that the ABORT message doesn't run
> on into any output from abort(3) and the associated signal backtracing.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 2b003d26d6b6b65b1d7b1dd6396f808c35b53177
>
> Diff: https://reviews.apache.org/r/39770/diff/
>
>
> Testing
> -------
>
> make check and manual testing.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 39770: Write a newline in ABORT().
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39770/#review104993
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp (line 53)
<https://reviews.apache.org/r/39770/#comment163352>
Why no EINTR loop on this additional write?
- Ben Mahler
On Oct. 29, 2015, 9:01 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39770/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 9:01 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3708
> https://issues.apache.org/jira/browse/MESOS-3708
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Write a newline in ABORT() so that the ABORT message doesn't run
> on into any output from abort(3) and the associated signal backtracing.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 2b003d26d6b6b65b1d7b1dd6396f808c35b53177
>
> Diff: https://reviews.apache.org/r/39770/diff/
>
>
> Testing
> -------
>
> make check and manual testing.
>
>
> Thanks,
>
> James Peach
>
>