You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2015/11/28 23:49:32 UTC
incubator-zeppelin git commit: ZEPPELIN-469 Interpreter process loads
unnecessary classes
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master 5951e6102 -> ddde27a7a
ZEPPELIN-469 Interpreter process loads unnecessary classes
Addresses issue https://issues.apache.org/jira/browse/ZEPPELIN-469
This PR fixes problem by remove `export ZEPPELIN_CLASSPATH`, so classpath from bin/zeppelin-daemon.sh is not propagated bin/interpreter.sh.
It can be verified by printing System classloader inside of notebook, like
```scala
val cl = ClassLoader.getSystemClassLoader()
val ucl = cl.asInstanceOf[java.net.URLClassLoader]
ucl.getURLs.foreach(u=>println(u))
```
Result is
Before
```
cl: ClassLoader = sun.misc.Launcher$AppClassLoader36c51089
ucl: java.net.URLClassLoader = sun.misc.Launcher$AppClassLoader36c51089
file:/zeppelin/
file:/zeppelin/
file:/zeppelin/interpreter/spark/dep/datanucleus-api-jdo-3.2.6.jar
file:/zeppelin/interpreter/spark/dep/datanucleus-core-3.2.10.jar
file:/zeppelin/interpreter/spark/dep/datanucleus-rdbms-3.2.9.jar
file:/zeppelin/interpreter/spark/dep/zeppelin-spark-dependencies-0.6.0-incubating-SNAPSHOT.jar
file:/zeppelin/interpreter/spark/zeppelin-spark-0.6.0-incubating-SNAPSHOT.jar
file:/zeppelin/lib/asm-3.1.jar
file:/zeppelin/lib/aws-java-sdk-core-1.10.1.jar
file:/zeppelin/lib/aws-java-sdk-kms-1.10.1.jar
file:/zeppelin/lib/aws-java-sdk-s3-1.10.1.jar
...
...
...
file:/zeppelin/lib/regexp-1.3.jar
file:/zeppelin/lib/scala-library-2.10.4.jar
file:/zeppelin/lib/slf4j-api-1.7.10.jar
file:/zeppelin/lib/slf4j-log4j12-1.7.10.jar
file:/zeppelin/lib/stax2-api-3.1.1.jar
file:/zeppelin/lib/woodstox-core-asl-4.2.0.jar
file:/zeppelin/lib/wsdl4j-1.6.3.jar
file:/zeppelin/lib/xml-apis-1.4.01.jar
file:/zeppelin/lib/xmlschema-core-2.0.3.jar
file:/zeppelin/lib/zeppelin-interpreter-0.6.0-incubating-SNAPSHOT.jar
file:/zeppelin/lib/zeppelin-zengine-0.6.0-incubating-SNAPSHOT.jar
file:/zeppelin/zeppelin-server-0.6.0-incubating-SNAPSHOT.jar
file:/zeppelin/
file:/zeppelin/conf/
file:/zeppelin/conf/
file:/zeppelin/conf/
```
After
```
cl: ClassLoader = sun.misc.Launcher$AppClassLoader338bd37a
ucl: java.net.URLClassLoader = sun.misc.Launcher$AppClassLoader338bd37a
file:/zeppelin/
file:/zeppelin/
file:/zeppelin/interpreter/spark/dep/datanucleus-api-jdo-3.2.6.jar
file:/zeppelin/interpreter/spark/dep/datanucleus-core-3.2.10.jar
file:/zeppelin/interpreter/spark/dep/datanucleus-rdbms-3.2.9.jar
file:/zeppelin/interpreter/spark/dep/zeppelin-spark-dependencies-0.6.0-incubating-SNAPSHOT.jar
file:/zeppelin/interpreter/spark/zeppelin-spark-0.6.0-incubating-SNAPSHOT.jar
file:/zeppelin/
file:/zeppelin/conf/
file:/zeppelin/conf/
```
Author: Lee moon soo <mo...@apache.org>
Closes #485 from Leemoonsoo/ZEPPELIN-469 and squashes the following commits:
63dcaaf [Lee moon soo] do not export ZEPPELIN_CLASSPATH
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/ddde27a7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/ddde27a7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/ddde27a7
Branch: refs/heads/master
Commit: ddde27a7abdc4e1357672b9489960a4a974ded44
Parents: 5951e61
Author: Lee moon soo <mo...@apache.org>
Authored: Fri Nov 27 20:41:37 2015 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Sun Nov 29 07:50:13 2015 +0900
----------------------------------------------------------------------
bin/common.sh | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/ddde27a7/bin/common.sh
----------------------------------------------------------------------
diff --git a/bin/common.sh b/bin/common.sh
index 2ed2d00..ae8b0bd 100644
--- a/bin/common.sh
+++ b/bin/common.sh
@@ -76,8 +76,6 @@ function addJarInDir(){
fi
}
-export ZEPPELIN_CLASSPATH
-
# Text encoding for
# read/write job into files,
# receiving/displaying query/result.