You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/02 22:39:02 UTC
Re: Review Request: Add tests for http decoding.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8798/
-----------------------------------------------------------
(Updated March 2, 2013, 9:39 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk.
Description
-------
See above.
Diffs (updated)
-----
third_party/libprocess/Makefile.am 71eb6805e5699984797389bb15f6d9f2c6d26b44
third_party/libprocess/include/process/http.hpp bc397e6f1d539d621b85d7ab36afb0237ceefca9
third_party/libprocess/src/decoder.hpp 253824f964845c8b7c9c29f31301b5b6c2c4a2f1
third_party/libprocess/src/process.cpp 8ae20b5d9ffc415e36e076ed78842aae7ddd4314
third_party/libprocess/src/tests/decoder_tests.cpp PRE-CREATION
third_party/libprocess/src/tests/main.cpp 0f1e9cbb2b869a53b979f138d3a89015f2bfbf56
Diff: https://reviews.apache.org/r/8798/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Add tests for http decoding.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8798/
-----------------------------------------------------------
(Updated March 5, 2013, 10:19 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
benh review + rebased off trunk.
Description
-------
See above.
Diffs (updated)
-----
third_party/libprocess/Makefile.am 71eb6805e5699984797389bb15f6d9f2c6d26b44
third_party/libprocess/include/process/http.hpp bc397e6f1d539d621b85d7ab36afb0237ceefca9
third_party/libprocess/src/decoder.hpp 253824f964845c8b7c9c29f31301b5b6c2c4a2f1
third_party/libprocess/src/process.cpp 8ae20b5d9ffc415e36e076ed78842aae7ddd4314
third_party/libprocess/src/tests/decoder_tests.cpp PRE-CREATION
third_party/libprocess/src/tests/main.cpp 0f1e9cbb2b869a53b979f138d3a89015f2bfbf56
Diff: https://reviews.apache.org/r/8798/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Add tests for http decoding.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8798/#review17396
-----------------------------------------------------------
Ship it!
third_party/libprocess/src/tests/decoder_tests.cpp
<https://reviews.apache.org/r/8798/#comment36918>
const& (here and everywhere else, including http encoding tests review).
third_party/libprocess/src/tests/decoder_tests.cpp
<https://reviews.apache.org/r/8798/#comment36917>
Missing some code here? Or just an extra newline?
- Benjamin Hindman
On March 2, 2013, 9:39 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8798/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 9:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> third_party/libprocess/Makefile.am 71eb6805e5699984797389bb15f6d9f2c6d26b44
> third_party/libprocess/include/process/http.hpp bc397e6f1d539d621b85d7ab36afb0237ceefca9
> third_party/libprocess/src/decoder.hpp 253824f964845c8b7c9c29f31301b5b6c2c4a2f1
> third_party/libprocess/src/process.cpp 8ae20b5d9ffc415e36e076ed78842aae7ddd4314
> third_party/libprocess/src/tests/decoder_tests.cpp PRE-CREATION
> third_party/libprocess/src/tests/main.cpp 0f1e9cbb2b869a53b979f138d3a89015f2bfbf56
>
> Diff: https://reviews.apache.org/r/8798/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>