You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by wa...@apache.org on 2022/11/11 05:41:11 UTC

[echarts-handbook] branch master updated: remove scroll-into-view from deps & fix description is not available

This is an automated email from the ASF dual-hosted git repository.

wangzx pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts-handbook.git


The following commit(s) were added to refs/heads/master by this push:
     new 83b5ec6  remove scroll-into-view from deps & fix description is not available
83b5ec6 is described below

commit 83b5ec6b7db47e1fc7dc331866f871b4a85bb650
Author: plainheart <yh...@all-my-life.cn>
AuthorDate: Fri Nov 11 13:39:04 2022 +0800

    remove scroll-into-view from deps & fix description is not available
---
 components/partials/Sidebar.vue | 12 +-----------
 nuxt.config.js                  |  3 ++-
 package-lock.json               | 11 -----------
 package.json                    |  1 -
 4 files changed, 3 insertions(+), 24 deletions(-)

diff --git a/components/partials/Sidebar.vue b/components/partials/Sidebar.vue
index 10d0e9e..8202c17 100644
--- a/components/partials/Sidebar.vue
+++ b/components/partials/Sidebar.vue
@@ -86,7 +86,6 @@
 
 <script lang="ts">
 import Vue from 'vue'
-import scrollIntoView from 'scroll-into-view'
 import SidebarNavItem from './SidebarNavItem.vue'
 
 export default Vue.extend({
@@ -107,16 +106,7 @@ export default Vue.extend({
 
   mounted() {
     const $actived = this.$el.querySelector('.nav-link.nuxt-link-active') as HTMLElement
-    if ($actived) {
-      scrollIntoView($actived, {
-        time: 0,
-        align: {
-          top: 0,
-          topOffset: 300
-        },
-        validTarget: target => target.className?.indexOf('bd-docs-nav') > -1
-      })
-    }
+    $actived?.scrollIntoView?.()
     // @ts-ignore
     docsearch({
       apiKey: '6ade5f1ff34e94690f9ea38cddcc2f55',
diff --git a/nuxt.config.js b/nuxt.config.js
index 2d57013..c5773d7 100644
--- a/nuxt.config.js
+++ b/nuxt.config.js
@@ -1,4 +1,5 @@
 import config from './configs/config'
+import { description } from './package.json'
 
 if (process.env.NODE_ENV === 'production') {
   console.log('Deploying to ...', process.env.NUXT_ENV_DEPLOY)
@@ -46,7 +47,7 @@ export default {
       {
         hid: 'description',
         name: 'description',
-        content: process.env.npm_package_description || ''
+        content: description || ''
       }
     ],
     link: [
diff --git a/package-lock.json b/package-lock.json
index 123460c..bc7fa9c 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -23,7 +23,6 @@
         "prism-themes": "^1.9.0",
         "prismjs": "^1.29.0",
         "resize-detector": "^0.3.0",
-        "scroll-into-view": "^1.16.2",
         "vanilla-lazyload": "^17.8.3",
         "vue": "2.6.14",
         "vue-observe-visibility": "^1.0.0",
@@ -15711,11 +15710,6 @@
         "url": "https://opencollective.com/webpack"
       }
     },
-    "node_modules/scroll-into-view": {
-      "version": "1.16.2",
-      "resolved": "https://registry.npmjs.org/scroll-into-view/-/scroll-into-view-1.16.2.tgz",
-      "integrity": "sha512-vyTE0i27o6eldt9xinjHec41Dw05y+faoI+s2zNKJAVOdbA5M2XZrYq/obJ8E+QDQulJ2gDjgui9w9m9RZSRng=="
-    },
     "node_modules/scule": {
       "version": "0.2.1",
       "resolved": "https://registry.npmjs.org/scule/-/scule-0.2.1.tgz",
@@ -31520,11 +31514,6 @@
         "ajv-keywords": "^3.5.2"
       }
     },
-    "scroll-into-view": {
-      "version": "1.16.2",
-      "resolved": "https://registry.npmjs.org/scroll-into-view/-/scroll-into-view-1.16.2.tgz",
-      "integrity": "sha512-vyTE0i27o6eldt9xinjHec41Dw05y+faoI+s2zNKJAVOdbA5M2XZrYq/obJ8E+QDQulJ2gDjgui9w9m9RZSRng=="
-    },
     "scule": {
       "version": "0.2.1",
       "resolved": "https://registry.npmjs.org/scule/-/scule-0.2.1.tgz",
diff --git a/package.json b/package.json
index ba986c3..9da8dd0 100644
--- a/package.json
+++ b/package.json
@@ -27,7 +27,6 @@
     "prism-themes": "^1.9.0",
     "prismjs": "^1.29.0",
     "resize-detector": "^0.3.0",
-    "scroll-into-view": "^1.16.2",
     "vanilla-lazyload": "^17.8.3",
     "vue": "2.6.14",
     "vue-observe-visibility": "^1.0.0",


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org