You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Christian Rapp (JIRA)" <ji...@codehaus.org> on 2010/11/30 10:45:05 UTC

[jira] Created: (MASSEMBLY-533) Outputidrectory appended by dependencyset include name on filtered=true

Outputidrectory appended by dependencyset include name on filtered=true
-----------------------------------------------------------------------

                 Key: MASSEMBLY-533
                 URL: http://jira.codehaus.org/browse/MASSEMBLY-533
             Project: Maven 2.x Assembly Plugin
          Issue Type: Bug
    Affects Versions: 2.2
            Reporter: Christian Rapp
            Priority: Critical
         Attachments: delivery_zip.xml, filtered_false.zip, filtered_true.zip, pom.xml

We are using this assembly descriptor:

{code:type=xml}
<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0 http://maven.apache.org/xsd/assembly-1.1.0.xsd">
  
  <id>Delivery</id>
  
  <formats>
    <format>zip</format>
  </formats>  
  
  <includeBaseDirectory>true</includeBaseDirectory>
  
  <dependencySets>  
    <dependencySet>
      <outputDirectory>.</outputDirectory>
      <unpack>true</unpack>
      <includes>
        <include>commons-collections:commons-collections:*</include>
      </includes>
      <useStrictFiltering>true</useStrictFiltering>
      <unpackOptions>        
        <includes>
          <include>META-INF/MANIFEST.MF</include>
        </includes>
        <filtered>true</filtered>
      </unpackOptions>
    </dependencySet>
  </dependencySets>
</assembly>
{code}.

When setting the property *filtered* to {{true}} in the second {{dependencySet}} an additional directory is created in assembly where the filtered {{build.properties}} file is included. If the property is set to {{false}} the additional directory is gone and the non-filtered file is set to the root of the assembly.

Attached you'll find 2 zip files:
* filtered_true.zip
* filtered_false.zip


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MASSEMBLY-533) Outputidrectory appended by dependencyset include name on filtered=true

Posted by "Christian Rapp (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Rapp closed MASSEMBLY-533.
------------------------------------

    Resolution: Not A Bug

After specifying the <outputFileNameMapping></outputFileNameMapping> the sub-dir was gone when filtered=true was set.

> Outputidrectory appended by dependencyset include name on filtered=true
> -----------------------------------------------------------------------
>
>                 Key: MASSEMBLY-533
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-533
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Christian Rapp
>            Priority: Critical
>         Attachments: delivery_zip.xml, filtered_false.zip, filtered_true.zip, pom.xml
>
>
> We are using this assembly descriptor:
> {code:type=xml}
> <assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0"
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>   xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0 http://maven.apache.org/xsd/assembly-1.1.0.xsd">
>   
>   <id>Delivery</id>
>   
>   <formats>
>     <format>zip</format>
>   </formats>  
>   
>   <includeBaseDirectory>true</includeBaseDirectory>
>   
>   <dependencySets>  
>     <dependencySet>
>       <outputDirectory>.</outputDirectory>
>       <unpack>true</unpack>
>       <includes>
>         <include>commons-collections:commons-collections:*</include>
>       </includes>
>       <useStrictFiltering>true</useStrictFiltering>
>       <unpackOptions>        
>         <includes>
>           <include>META-INF/MANIFEST.MF</include>
>         </includes>
>         <filtered>true</filtered>
>       </unpackOptions>
>     </dependencySet>
>   </dependencySets>
> </assembly>
> {code}.
> When setting the property *filtered* to {{true}} in the second {{dependencySet}} an additional directory is created in assembly where the filtered {{build.properties}} file is included. If the property is set to {{false}} the additional directory is gone and the non-filtered file is set to the root of the assembly.
> Attached you'll find 2 zip files:
> * filtered_true.zip
> * filtered_false.zip

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MASSEMBLY-533) Outputidrectory appended by dependencyset include name on filtered=true

Posted by "Benjamin Reed (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MASSEMBLY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=246654#action_246654 ] 

Benjamin Reed commented on MASSEMBLY-533:
-----------------------------------------

Curious, why did you close this?  Seems like it should still be a bug, shouldn't it?  Even if there's a workaround...

I'm seeing this exact same behavior, I was having a hell of a time figuring out why my filtered ones would be different.  :P

> Outputidrectory appended by dependencyset include name on filtered=true
> -----------------------------------------------------------------------
>
>                 Key: MASSEMBLY-533
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-533
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Christian Rapp
>            Priority: Critical
>         Attachments: delivery_zip.xml, filtered_false.zip, filtered_true.zip, pom.xml
>
>
> We are using this assembly descriptor:
> {code:type=xml}
> <assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0"
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>   xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0 http://maven.apache.org/xsd/assembly-1.1.0.xsd">
>   
>   <id>Delivery</id>
>   
>   <formats>
>     <format>zip</format>
>   </formats>  
>   
>   <includeBaseDirectory>true</includeBaseDirectory>
>   
>   <dependencySets>  
>     <dependencySet>
>       <outputDirectory>.</outputDirectory>
>       <unpack>true</unpack>
>       <includes>
>         <include>commons-collections:commons-collections:*</include>
>       </includes>
>       <useStrictFiltering>true</useStrictFiltering>
>       <unpackOptions>        
>         <includes>
>           <include>META-INF/MANIFEST.MF</include>
>         </includes>
>         <filtered>true</filtered>
>       </unpackOptions>
>     </dependencySet>
>   </dependencySets>
> </assembly>
> {code}.
> When setting the property *filtered* to {{true}} in the second {{dependencySet}} an additional directory is created in assembly where the filtered {{build.properties}} file is included. If the property is set to {{false}} the additional directory is gone and the non-filtered file is set to the root of the assembly.
> Attached you'll find 2 zip files:
> * filtered_true.zip
> * filtered_false.zip

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MASSEMBLY-533) Outputidrectory appended by dependencyset include name on filtered=true

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MASSEMBLY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MASSEMBLY-533:
--------------------------------------

    Component/s: filtering
    
> Outputidrectory appended by dependencyset include name on filtered=true
> -----------------------------------------------------------------------
>
>                 Key: MASSEMBLY-533
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-533
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>          Components: filtering
>    Affects Versions: 2.2
>            Reporter: Christian Rapp
>            Priority: Critical
>         Attachments: delivery_zip.xml, filtered_false.zip, filtered_true.zip, pom.xml
>
>
> We are using this assembly descriptor:
> {code:type=xml}
> <assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0"
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>   xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0 http://maven.apache.org/xsd/assembly-1.1.0.xsd">
>   
>   <id>Delivery</id>
>   
>   <formats>
>     <format>zip</format>
>   </formats>  
>   
>   <includeBaseDirectory>true</includeBaseDirectory>
>   
>   <dependencySets>  
>     <dependencySet>
>       <outputDirectory>.</outputDirectory>
>       <unpack>true</unpack>
>       <includes>
>         <include>commons-collections:commons-collections:*</include>
>       </includes>
>       <useStrictFiltering>true</useStrictFiltering>
>       <unpackOptions>        
>         <includes>
>           <include>META-INF/MANIFEST.MF</include>
>         </includes>
>         <filtered>true</filtered>
>       </unpackOptions>
>     </dependencySet>
>   </dependencySets>
> </assembly>
> {code}.
> When setting the property *filtered* to {{true}} in the second {{dependencySet}} an additional directory is created in assembly where the filtered {{build.properties}} file is included. If the property is set to {{false}} the additional directory is gone and the non-filtered file is set to the root of the assembly.
> Attached you'll find 2 zip files:
> * filtered_true.zip
> * filtered_false.zip

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (MASSEMBLY-533) Outputidrectory appended by dependencyset include name on filtered=true

Posted by "Christian Rapp (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Rapp reopened MASSEMBLY-533:
--------------------------------------


I open it, because more users are running into the same problem. And yes, behavior of the plugin should be the same no matter if filtering is turned on/off.

> Outputidrectory appended by dependencyset include name on filtered=true
> -----------------------------------------------------------------------
>
>                 Key: MASSEMBLY-533
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-533
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Christian Rapp
>            Priority: Critical
>         Attachments: delivery_zip.xml, filtered_false.zip, filtered_true.zip, pom.xml
>
>
> We are using this assembly descriptor:
> {code:type=xml}
> <assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0"
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>   xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0 http://maven.apache.org/xsd/assembly-1.1.0.xsd">
>   
>   <id>Delivery</id>
>   
>   <formats>
>     <format>zip</format>
>   </formats>  
>   
>   <includeBaseDirectory>true</includeBaseDirectory>
>   
>   <dependencySets>  
>     <dependencySet>
>       <outputDirectory>.</outputDirectory>
>       <unpack>true</unpack>
>       <includes>
>         <include>commons-collections:commons-collections:*</include>
>       </includes>
>       <useStrictFiltering>true</useStrictFiltering>
>       <unpackOptions>        
>         <includes>
>           <include>META-INF/MANIFEST.MF</include>
>         </includes>
>         <filtered>true</filtered>
>       </unpackOptions>
>     </dependencySet>
>   </dependencySets>
> </assembly>
> {code}.
> When setting the property *filtered* to {{true}} in the second {{dependencySet}} an additional directory is created in assembly where the filtered {{build.properties}} file is included. If the property is set to {{false}} the additional directory is gone and the non-filtered file is set to the root of the assembly.
> Attached you'll find 2 zip files:
> * filtered_true.zip
> * filtered_false.zip

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MASSEMBLY-533) Outputidrectory appended by dependencyset include name on filtered=true

Posted by "Christian Rapp (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Rapp updated MASSEMBLY-533:
-------------------------------------

    Attachment: delivery_zip.xml

> Outputidrectory appended by dependencyset include name on filtered=true
> -----------------------------------------------------------------------
>
>                 Key: MASSEMBLY-533
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-533
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Christian Rapp
>            Priority: Critical
>         Attachments: delivery_zip.xml, filtered_false.zip, filtered_true.zip, pom.xml
>
>
> We are using this assembly descriptor:
> {code:type=xml}
> <assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0"
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>   xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0 http://maven.apache.org/xsd/assembly-1.1.0.xsd">
>   
>   <id>Delivery</id>
>   
>   <formats>
>     <format>zip</format>
>   </formats>  
>   
>   <includeBaseDirectory>true</includeBaseDirectory>
>   
>   <dependencySets>  
>     <dependencySet>
>       <outputDirectory>.</outputDirectory>
>       <unpack>true</unpack>
>       <includes>
>         <include>commons-collections:commons-collections:*</include>
>       </includes>
>       <useStrictFiltering>true</useStrictFiltering>
>       <unpackOptions>        
>         <includes>
>           <include>META-INF/MANIFEST.MF</include>
>         </includes>
>         <filtered>true</filtered>
>       </unpackOptions>
>     </dependencySet>
>   </dependencySets>
> </assembly>
> {code}.
> When setting the property *filtered* to {{true}} in the second {{dependencySet}} an additional directory is created in assembly where the filtered {{build.properties}} file is included. If the property is set to {{false}} the additional directory is gone and the non-filtered file is set to the root of the assembly.
> Attached you'll find 2 zip files:
> * filtered_true.zip
> * filtered_false.zip

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira