You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/13 04:56:15 UTC
[GitHub] [airflow] sharon2719 opened a new pull request #18930: pinot operators guide #8194
sharon2719 opened a new pull request #18930:
URL: https://github.com/apache/airflow/pull/18930
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-961298049
@sharon2719 There are still many unrelated changes in the branch (lower than before tough) please remove all unrelated code changes you can see in https://github.com/apache/airflow/pull/18930/files the files that you are modifying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharon2719 closed pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
sharon2719 closed pull request #18930:
URL: https://github.com/apache/airflow/pull/18930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-961298049
@sharon2719 There are still many unrelated changes in the branch (lower than before tough) please remove all unrelated code changes you can see in https://github.com/apache/airflow/pull/18930/files the files that you are modifying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharon2719 closed pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
sharon2719 closed pull request #18930:
URL: https://github.com/apache/airflow/pull/18930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharon2719 edited a comment on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
sharon2719 edited a comment on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-953508074
I have rebased it but I still dont get why it is still pushing with the unrelated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18930: pinot operators guide #8194
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-941921101
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a change in pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
josh-fell commented on a change in pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#discussion_r730258954
##########
File path: airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Example DAG demonstrating the usage of the PinotAdminHook and PinotDbApiHook."""
+
+from airflow import DAG
+from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook, PinotDbApiHook
+from airflow.utils.dates import days_ago
+
+with DAG(
+ dag_id='example_pinot_hook',
+ schedule_interval=None,
+ start_date=days_ago(2),
+ tags=['example'],
+) as dag:
+
+ # [START howto_operator_pinot_admin_hook]
+ run_this = PinotAdminHook(
+ task_id="run_example_pinot_script",
+ pinot="ls /;",
+ pinot_options="-x local",
+
+)
+ # [END howto_operator_pinot_admin_hook]
+
+ # [START howto_operator_pinot_dbapi_example]
+
+ run_this = PinotDbApiHook(
+ task_id="run_example_pinot_script",
+ pinot="ls /;",
+ pinot_options="-x local",
+ dag=dag,
Review comment:
This can be removed since the `DAG` object is being used as a context manager which takes care of passing this arg to all operators.
##########
File path: airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Example DAG demonstrating the usage of the PinotAdminHook and PinotDbApiHook."""
+
+from airflow import DAG
+from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook, PinotDbApiHook
+from airflow.utils.dates import days_ago
+
+with DAG(
+ dag_id='example_pinot_hook',
+ schedule_interval=None,
+ start_date=days_ago(2),
+ tags=['example'],
+) as dag:
+
+ # [START howto_operator_pinot_admin_hook]
+ run_this = PinotAdminHook(
+ task_id="run_example_pinot_script",
+ pinot="ls /;",
+ pinot_options="-x local",
+
+)
+ # [END howto_operator_pinot_admin_hook]
+
+ # [START howto_operator_pinot_dbapi_example]
+
+ run_this = PinotDbApiHook(
+ task_id="run_example_pinot_script",
+ pinot="ls /;",
+ pinot_options="-x local",
+ dag=dag,
Review comment:
Would it be possible to show different args for `pinot` and `pinot_options` parameters? Otherwise, seeing as the same args are used for every operator in the DAG, these ideally should be present as `default_args` at the DAG level. However, because the operator documentation is referencing the example DAG, moving the args to `default_args` loses the main context for showcasing the operators in the documentation.
Updating the args to be different between the two would preclude the `default_args` use. I'm not sure if they need to be the same value when using these operators together in a pipeline though.
##########
File path: docs/apache-airflow-providers-apache-pinot/operators.rst
##########
@@ -0,0 +1,75 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+``airflow.providers.apache.pinot.hooks.pinot``
+==============================================
+
+Content
+-------
+
+Apache Pinot Hooks
+==================
+
+`Apache Pinot <https://pinot.apache.org/>`__ is a column-oriented, open-source,distributed data store written in Java. Pinot is designed to execute OLAP querieswith low latency. It is suited in contexts where fast analytics, such as aggregations,are needed on immutable data, possibly, with real-time data ingestion.
+
+Prerequisite
+------------
+
+.. To use Pinot hooks, you must configure :doc:`Pinot Connection <connections/pinot>`.
+
+.. _howto/operator:PinotHooks:
+
+PinotAdminHook
+--------------
+
+This hook is a wrapper around the pinot-admin.sh script. For now, only small subset of its subcommands are implemented, which are required to ingest offline data into Apache Pinot (i.e., AddSchema, AddTable, CreateSegment, and UploadSegment). Their command options are based on Pinot v0.1.0.
+
+Parameters
+----------
+
+For parameter definition, take a look at :class:`~airflow.providers.apache.pinot.hooks.pinot.PinotAdminHook`
+
+.. exampleinclude:: /../../airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
+ :language: python
+ :start-after: [START howto_operator_pinot_admin_hook]
+ :end-before: [END howto_operator_pinot_admin_hook]
+
+Reference
+^^^^^^^^^
+For more information,please see the documentation at `Apache Pinot improvements for PinotAdminHook<https://github.com/apache/incubator-pinot/pull/4110>`
+
+PinotDbApiHook
+--------------
+
+This hook uses standard-SQL endpoint. PQL endpoint is removed in updated versions of pinotdb library. For more information see `library documentation <https://docs.pinot.apache.org/users/clients/python>`
+
+Parameters
+----------
+
+For parameter definition, take a look at :class:`~classairflow.providers.apache.pinot.hooks.pinot.PinotDbApiHook`
+
+.. exampleinclude:: /../../airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
+ :language: python
+ :start-after: [START howto_operator_pinot_dbapi_example]
+ :end-before: [END howto_operator_pinot_dbapi_example]
+
+Reference
+^^^^^^^^^
+
+For more information, please see the documentation at `Pinot documentation on querrying data <https://docs.pinot.apache.org/users/api/querying-pinot-using-standard-sql>`
Review comment:
"querrying" should be spelled "querying"
##########
File path: airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Example DAG demonstrating the usage of the PinotAdminHook and PinotDbApiHook."""
+
+from airflow import DAG
+from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook, PinotDbApiHook
+from airflow.utils.dates import days_ago
+
+with DAG(
+ dag_id='example_pinot_hook',
+ schedule_interval=None,
+ start_date=days_ago(2),
Review comment:
We are currently transitioning all of the example DAGs (and later docs) away from using `days_ago(n)` for `start_date` to a static value since it's best practice when writing pipelines. New examples should use a static `start_date` value. The updates have been using `datetime()`; the actual value doesn't matter.
##########
File path: docs/apache-airflow-providers-apache-pinot/operators.rst
##########
@@ -0,0 +1,75 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+``airflow.providers.apache.pinot.hooks.pinot``
+==============================================
+
+Content
+-------
+
+Apache Pinot Hooks
+==================
+
+`Apache Pinot <https://pinot.apache.org/>`__ is a column-oriented, open-source,distributed data store written in Java. Pinot is designed to execute OLAP querieswith low latency. It is suited in contexts where fast analytics, such as aggregations,are needed on immutable data, possibly, with real-time data ingestion.
Review comment:
Small nit for spaces:
> ... a column-oriented, open-source,distributed data store written in Java
"... column-oriented, open-source, distributed data store written in Java"
> ... such as aggregations,are needed
"... such as aggregations, are needed ...
##########
File path: docs/apache-airflow-providers-apache-pinot/operators.rst
##########
@@ -0,0 +1,75 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+``airflow.providers.apache.pinot.hooks.pinot``
+==============================================
+
+Content
+-------
+
+Apache Pinot Hooks
+==================
+
+`Apache Pinot <https://pinot.apache.org/>`__ is a column-oriented, open-source,distributed data store written in Java. Pinot is designed to execute OLAP querieswith low latency. It is suited in contexts where fast analytics, such as aggregations,are needed on immutable data, possibly, with real-time data ingestion.
+
+Prerequisite
+------------
+
+.. To use Pinot hooks, you must configure :doc:`Pinot Connection <connections/pinot>`.
+
+.. _howto/operator:PinotHooks:
+
+PinotAdminHook
+--------------
+
+This hook is a wrapper around the pinot-admin.sh script. For now, only small subset of its subcommands are implemented, which are required to ingest offline data into Apache Pinot (i.e., AddSchema, AddTable, CreateSegment, and UploadSegment). Their command options are based on Pinot v0.1.0.
+
+Parameters
+----------
+
+For parameter definition, take a look at :class:`~airflow.providers.apache.pinot.hooks.pinot.PinotAdminHook`
+
+.. exampleinclude:: /../../airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
+ :language: python
+ :start-after: [START howto_operator_pinot_admin_hook]
+ :end-before: [END howto_operator_pinot_admin_hook]
+
+Reference
+^^^^^^^^^
+For more information,please see the documentation at `Apache Pinot improvements for PinotAdminHook<https://github.com/apache/incubator-pinot/pull/4110>`
Review comment:
Another small nit for a space between "information,please"
##########
File path: airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Example DAG demonstrating the usage of the PinotAdminHook and PinotDbApiHook."""
+
+from airflow import DAG
+from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook, PinotDbApiHook
+from airflow.utils.dates import days_ago
+
+with DAG(
+ dag_id='example_pinot_hook',
+ schedule_interval=None,
+ start_date=days_ago(2),
+ tags=['example'],
+) as dag:
+
+ # [START howto_operator_pinot_admin_hook]
+ run_this = PinotAdminHook(
+ task_id="run_example_pinot_script",
+ pinot="ls /;",
+ pinot_options="-x local",
+
+)
+ # [END howto_operator_pinot_admin_hook]
+
+ # [START howto_operator_pinot_dbapi_example]
+
+ run_this = PinotDbApiHook(
+ task_id="run_example_pinot_script",
+ pinot="ls /;",
+ pinot_options="-x local",
+ dag=dag,
Review comment:
The `dag=dag` can be removed since the `DAG` object is being used as a context manager which takes care of passing this arg to all operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-961298049
@sharon2719 There are still many unrelated changes in the branch (lower than before tough) please remove all unrelated code changes you can see in https://github.com/apache/airflow/pull/18930/files the files that you are modifying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharon2719 closed pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
sharon2719 closed pull request #18930:
URL: https://github.com/apache/airflow/pull/18930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-953119959
> Was the `=2.1.0` file accidentally committed?
I wen't ahead and deleted it via Github UI :). Nice catch @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #18930:
URL: https://github.com/apache/airflow/pull/18930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] theodesp commented on a change in pull request #18930: pinot operators guide #8194
Posted by GitBox <gi...@apache.org>.
theodesp commented on a change in pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#discussion_r727988326
##########
File path: docs/apache-airflow-providers-apache-beam/operators.rst
##########
@@ -84,7 +85,7 @@ Run Java Pipelines in Apache Beam
For Java pipeline the ``jar`` argument must be specified for
:class:`~airflow.providers.apache.beam.operators.beam.BeamRunJavaPipelineOperator`
as it contains the pipeline to be executed by Apache Beam. The JAR can be available on GCS that Airflow
-has the ability to download or available on the local filesystem (provide the absolute path to it).
+has the ability to download or available on the local filesystem (provide the absolute path to it).
Review comment:
```suggestion
has the ability to download or available on the local filesystem (provide the absolute path to it).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-947195510
Looks like there are many unrelated changes in the PR. I think you should rebase to latest `main` and only leave the "Apache Pinot" related changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharon2719 commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
sharon2719 commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-953508074
> It seems like the merge (or rebase?) didn't went well and pulled in a ton of unrelated things...
- [ ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18930: pinot operators guide #8194
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-941921101
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharon2719 commented on pull request #18930: pinot operators guide #8194
Posted by GitBox <gi...@apache.org>.
sharon2719 commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-944867344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] theodesp commented on a change in pull request #18930: pinot operators guide #8194
Posted by GitBox <gi...@apache.org>.
theodesp commented on a change in pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#discussion_r727988819
##########
File path: docs/apache-airflow-providers-apache-pinot/pinot-operators.rst
##########
@@ -0,0 +1,140 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Guide for Apache Pinot Operators
+=================================
+
+
+`Apache Pinot <https://pinot.apache.org/>`__ is a column-oriented, open-source,
+distributed data store written in Java. Pinot is designed to execute OLAP queries
+with low latency. It is suited in contexts where fast analytics,such as aggregations,
Review comment:
```suggestion
with low latency. It is suited in contexts where fast analytics, such as aggregations,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18930: pinot operators guide #8194
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-944875517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-953506387
It seems like the merge (or rebase?) didn't went well and pulled in a ton of unrelated things...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-953000663
Was the `=2.1.0` file accidentally committed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-953197944
> Why there are changes to airflow/_vendor/connexion/ ?
Indeed - should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-953515482
I think this is rebased to the wrong base. Not sure what the best way to recover is; personally I usually `cherry-pick` the commits manually back:
```
# Assumes 'origin' points to apache/airflow -- adjust 'origin' as needed.
git fetch origin main
git branch -f main origin/main # Point the local 'main' to the origin's main.
git checkout main
git cherry-pick e700a59ae85beb7bbfbd25153b4d9eeb3c78a9d8 # Manully apply the commit's changes again.
git push --force
```
To avoid this from happening again, it is best to *avoid making changes on your own 'main' directly*, but instead *create a branch for each pull request*. Since this PR is already submitted, it is not possible to change the originating branch now, but this is a good approach to remember if you plan to make other pull requests in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharon2719 closed pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
sharon2719 closed pull request #18930:
URL: https://github.com/apache/airflow/pull/18930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-953194491
I think there are unrelated changes in that PR.
Why there are changes to `airflow/_vendor/connexion/ `?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#discussion_r730683155
##########
File path: docs/apache-airflow-providers-apache-pinot/operators.rst
##########
@@ -0,0 +1,74 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+``airflow.providers.apache.pinot.hooks.pinot``
+==============================================
+
+Content
+-------
+
+Apache Pinot Hooks
+==================
+
+`Apache Pinot <https://pinot.apache.org/>`__ is a column-oriented, open-source,distributed data store written in Java. Pinot is designed to execute OLAP querieswith low latency. It is suited in contexts where fast analytics, such as aggregations,are needed on immutable data, possibly, with real-time data ingestion.
Review comment:
```suggestion
`Apache Pinot <https://pinot.apache.org/>`__ is a column-oriented, open-source, distributed data store written in Java. Pinot is designed to execute OLAP queries with low latency. It is suited in contexts where fast analytics, such as aggregations are needed on immutable data, possibly, with real-time data ingestion.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-1001085662
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] theodesp commented on a change in pull request #18930: pinot operators guide #8194
Posted by GitBox <gi...@apache.org>.
theodesp commented on a change in pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#discussion_r727988326
##########
File path: docs/apache-airflow-providers-apache-beam/operators.rst
##########
@@ -84,7 +85,7 @@ Run Java Pipelines in Apache Beam
For Java pipeline the ``jar`` argument must be specified for
:class:`~airflow.providers.apache.beam.operators.beam.BeamRunJavaPipelineOperator`
as it contains the pipeline to be executed by Apache Beam. The JAR can be available on GCS that Airflow
-has the ability to download or available on the local filesystem (provide the absolute path to it).
+has the ability to download or available on the local filesystem (provide the absolute path to it).
Review comment:
```suggestion
has the ability to download or available on the local filesystem (provide the absolute path to it).
```
##########
File path: docs/apache-airflow-providers-apache-pinot/pinot-operators.rst
##########
@@ -0,0 +1,140 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Guide for Apache Pinot Operators
+=================================
+
+
+`Apache Pinot <https://pinot.apache.org/>`__ is a column-oriented, open-source,
+distributed data store written in Java. Pinot is designed to execute OLAP queries
+with low latency. It is suited in contexts where fast analytics,such as aggregations,
Review comment:
```suggestion
with low latency. It is suited in contexts where fast analytics, such as aggregations,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #18930: pinot operators guide #8194
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#discussion_r730226523
##########
File path: docs/apache-airflow-providers-apache-beam/operators.rst
##########
@@ -76,6 +76,7 @@ Python Pipelines with DataflowRunner
:start-after: [START howto_operator_start_python_dataflow_runner_pipeline_async_gcs_file]
:end-before: [END howto_operator_start_python_dataflow_runner_pipeline_async_gcs_file]
+
Review comment:
```suggestion
```
##########
File path: docs/apache-airflow/concepts/operators.rst
##########
@@ -16,7 +16,7 @@
under the License.
Operators
-=========
+==========
Review comment:
```suggestion
=========
```
##########
File path: docs/apache-airflow-providers-apache-pinot/operators.rst
##########
@@ -0,0 +1,75 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+``airflow.providers.apache.pinot.hooks.pinot``
+==============================================
+
+Content
+-------
+
+Apache Pinot Hooks
+==================
+
+`Apache Pinot <https://pinot.apache.org/>`__ is a column-oriented, open-source,distributed data store written in Java. Pinot is designed to execute OLAP querieswith low latency. It is suited in contexts where fast analytics, such as aggregations,are needed on immutable data, possibly, with real-time data ingestion.
+
+Prerequisite
+------------
+
+.. To use Pinot hooks, you must configure :doc:`Pinot Connection <connections/pinot>`.
+
+.. _howto/operator:PinotHooks:
+
+PinotAdminHook
+--------------
+
+This hook is a wrapper around the pinot-admin.sh script. For now, only small subset of its subcommands are implemented, which are required to ingest offline data into Apache Pinot (i.e., AddSchema, AddTable, CreateSegment, and UploadSegment). Their command options are based on Pinot v0.1.0.
+
+Parameters
+----------
+
+For parameter definition, take a look at :class:`~airflow.providers.apache.pinot.hooks.pinot.PinotAdminHook`
+
+.. exampleinclude:: /../../airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
+ :language: python
+ :start-after: [START howto_operator_pinot_admin_hook]
+ :end-before: [END howto_operator_pinot_admin_hook]
+
+Reference
+^^^^^^^^^
+For more information,please see the documentation at `Apache Pinot improvements for PinotAdminHook<https://github.com/apache/incubator-pinot/pull/4110>`
+
+PinotDbApiHook
+--------------
+
+This hook uses standard-SQL endpoint since PQL endpoint is soon to be deprecated.
Review comment:
```suggestion
This hook uses standard-SQL endpoint. PQL endpoint is removed in updated versions of pinotdb library. For more information see `library documentation <https://docs.pinot.apache.org/users/clients/python>`
```
##########
File path: airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
##########
@@ -0,0 +1,49 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Example DAG demonstrating the usage of the PinotAdminHook and PinotDbApiHook."""
+
+from airflow import DAG
+from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook
+from airflow.providers.apache.pinot.hooks.pinot import PinotDbApiHook
Review comment:
```suggestion
from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook, PinotDbApiHook
```
##########
File path: docs/apache-airflow-providers-apache-pinot/operators.rst
##########
@@ -0,0 +1,75 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+``airflow.providers.apache.pinot.hooks.pinot``
+==============================================
+
+Content
+-------
+
+Apache Pinot Hooks
+==================
+
+`Apache Pinot <https://pinot.apache.org/>`__ is a column-oriented, open-source,distributed data store written in Java. Pinot is designed to execute OLAP querieswith low latency. It is suited in contexts where fast analytics, such as aggregations,are needed on immutable data, possibly, with real-time data ingestion.
+
+Prerequisite
+------------
+
+.. To use Pinot hooks, you must configure :doc:`Pinot Connection <connections/pinot>`.
+
+.. _howto/operator:PinotHooks:
+
+PinotAdminHook
+--------------
+
+This hook is a wrapper around the pinot-admin.sh script. For now, only small subset of its subcommands are implemented, which are required to ingest offline data into Apache Pinot (i.e., AddSchema, AddTable, CreateSegment, and UploadSegment). Their command options are based on Pinot v0.1.0.
+
+Parameters
+----------
+
+For parameter definition, take a look at :class:`~airflow.providers.apache.pinot.hooks.pinot.PinotAdminHook`
+
+.. exampleinclude:: /../../airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
+ :language: python
+ :start-after: [START howto_operator_pinot_admin_hook]
+ :end-before: [END howto_operator_pinot_admin_hook]
+
+Reference
+^^^^^^^^^
+For more information,please see the documentation at `Apache Pinot improvements for PinotAdminHook<https://github.com/apache/incubator-pinot/pull/4110>`
Review comment:
Why do we link to a PR and not to official documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharon2719 closed pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
sharon2719 closed pull request #18930:
URL: https://github.com/apache/airflow/pull/18930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on pull request #18930: Add Guide for Apache Pinot
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on pull request #18930:
URL: https://github.com/apache/airflow/pull/18930#issuecomment-953515482
I think this is rebased to the wrong base. Not sure what the best way to recover is; personally I usually `cherry-pick` the commits manually back:
```bash
# Assumes 'origin' points to apache/airflow -- adjust 'origin' as needed.
git fetch origin main
git branch -f main origin/main # Point the local 'main' to the origin's main.
git checkout main
git cherry-pick e700a59ae85beb7bbfbd25153b4d9eeb3c78a9d8 # Manully apply the commit's changes again.
git push --force
```
To avoid this from happening again, it is best to *avoid making changes on your own 'main' directly*, but instead *create a branch for each pull request*. Since this PR is already submitted, it is not possible to change the originating branch now, but this is a good approach to remember if you plan to make other pull requests in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org