You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/03/07 14:49:15 UTC

[GitHub] [zeppelin] liuxunorg opened a new pull request #3322: [ZEPPELIN-4039] Fix restart interpreter process throws ConcurrentModificationException

liuxunorg opened a new pull request #3322: [ZEPPELIN-4039] Fix restart interpreter process throws ConcurrentModificationException
URL: https://github.com/apache/zeppelin/pull/3322
 
 
   ### What is this PR for?
   1. Set in zeppelin-env.sh `export ZEPPELIN_FORCE_STOP=true`
   2. Create an interpreter process container in the remote YARN.
   3. When restart this interpreter, The interpreter process container will have a ConcurrentModificationException and will not exit properly.
   
   The reason for this BUG is: When `export ZEPPELIN_FORCE_STOP=true`,
   Restart the interpreter process, the zeppelin server will execute the session that closes the process.
   At the same time, the `shutdown()` and `close()` will be remote call.
   
   In the RemoteInterpreterServer, the `shutdown()` and `close()` functions do not have concurrency control on the interpreterGroup, Causes an exception.
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4039
   
   ### How should this be tested?
   * Set in zeppelin-env.sh `export ZEPPELIN_FORCE_STOP=true`
   * Create an interpreter process container in the remote YARN.
   * Restart this interpreter.
   
   ### Screenshots (if appropriate)
   ![restart-interpreter-concurrentmodificationexception](https://user-images.githubusercontent.com/3677382/53964731-d46f3300-412a-11e9-80c0-62629f6bb5e8.gif)
   
   
   [CI pass](https://travis-ci.org/liuxunorg/zeppelin/builds/503097844)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services