You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/09/09 13:16:32 UTC
[GitHub] [incubator-pegasus] empiredan opened a new pull request, #1158: fix: fix invalid logging format for meta server_state
empiredan opened a new pull request, #1158:
URL: https://github.com/apache/incubator-pegasus/pull/1158
This PR is to fix https://github.com/apache/incubator-pegasus/issues/1157.
This issue must be caused by invalid logging format as follows:
```C++
dassert(false,
"gpid({}) on node({}) is not exist on meta server, administrator "
"should check consistency of meta data",
rep.pid,
request.node.to_string());
```
For `{}` in logging, `dassert_f` should be used instead of `dassert`. This PR has also replaced all logging format with `*_f` for meta server_state, including:
- dassert -> dassert_f
- derror -> derror_f
- dwarn -> dwarn_f
- ddebug -> ddebug_f
- dinfo -> dinfo_f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on pull request #1158: fix: fix invalid logging format for meta server_state
Posted by GitBox <gi...@apache.org>.
empiredan commented on PR #1158:
URL: https://github.com/apache/incubator-pegasus/pull/1158#issuecomment-1304609177
This issue has been fixed by https://github.com/apache/incubator-pegasus/pull/1217.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan closed pull request #1158: fix: fix invalid logging format for meta server_state
Posted by GitBox <gi...@apache.org>.
empiredan closed pull request #1158: fix: fix invalid logging format for meta server_state
URL: https://github.com/apache/incubator-pegasus/pull/1158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org