You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "FreeAndNil (via GitHub)" <gi...@apache.org> on 2025/04/15 20:02:28 UTC
[PR] cleanup changes for Antora (logging-log4net)
FreeAndNil opened a new pull request, #238:
URL: https://github.com/apache/logging-log4net/pull/238
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanup changes for Antora (logging-log4net)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #238:
URL: https://github.com/apache/logging-log4net/pull/238#discussion_r2046222199
##########
antora-playbook.yaml:
##########
@@ -109,6 +109,9 @@ ui:
<span class="navbar-item title">{{site.title}}</span>
</div>
<div id="topbar-nav" class="navbar-menu">
+ <div class="navbar-end">
+ <a class="navbar-item" href="https://github.com/apache/logging-log4net">Github</a>
Review Comment:
```suggestion
<a class="navbar-item" href="https://github.com/apache/logging-log4net">GitHub</a>
```
##########
src/site/antora/antora.yml:
##########
@@ -38,10 +38,10 @@ version: ~
start_page: index.adoc
asciidoc:
attributes:
- project-github-url: "https://github.com/apache/logging-log4j-tools"
- project-version: "1.2.3"
- project-name: "Log4j Tools"
- project-id: "log4j-tools"
+ project-github-url: "https://github.com/apache/logging-log4net"
+ project-version: "3.1.0"
Review Comment:
You can leave this containing a value that it is clear a dummy one. This file is auto-generated anyway. Content here is just a stub.
```suggestion
project-version: "1.2.3"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanup changes for Antora (logging-log4net)
Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil commented on code in PR #238:
URL: https://github.com/apache/logging-log4net/pull/238#discussion_r2046327877
##########
antora-playbook.yaml:
##########
@@ -109,6 +109,9 @@ ui:
<span class="navbar-item title">{{site.title}}</span>
</div>
<div id="topbar-nav" class="navbar-menu">
+ <div class="navbar-end">
+ <a class="navbar-item" href="https://github.com/apache/logging-log4net">Github</a>
Review Comment:
Thanks. `./mvnw site` runs successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanup changes for Antora (logging-log4net)
Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil merged PR #238:
URL: https://github.com/apache/logging-log4net/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanup changes for Antora (logging-log4net)
Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil commented on code in PR #238:
URL: https://github.com/apache/logging-log4net/pull/238#discussion_r2046329191
##########
src/site/antora/antora.yml:
##########
@@ -38,10 +38,10 @@ version: ~
start_page: index.adoc
asciidoc:
attributes:
- project-github-url: "https://github.com/apache/logging-log4j-tools"
- project-version: "1.2.3"
- project-name: "Log4j Tools"
- project-id: "log4j-tools"
+ project-github-url: "https://github.com/apache/logging-log4net"
+ project-version: "3.1.0"
Review Comment:
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org