You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Supreeth Sharma <su...@gmail.com> on 2017/04/21 12:02:34 UTC
Review Request 58613: Need to show appropriate error message while
deleting the workflow history in project manager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58613/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
Repository: ambari
Description
-------
Changed the message to indicate that item is getting deleted only from the history and file will still be available in HDFS file path
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js ed448d9
contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less abb0637
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 05599e5
Diff: https://reviews.apache.org/r/58613/diff/1/
Testing
-------
Manually tested the changes
Thanks,
Supreeth Sharma
Re: Review Request 58613: Need to show appropriate error message while
deleting the workflow history in project manager
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58613/#review172631
-----------------------------------------------------------
Ship it!
Ship It!
- venkat sairam
On April 21, 2017, 12:02 p.m., Supreeth Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58613/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 12:02 p.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changed the message to indicate that item is getting deleted only from the history and file will still be available in HDFS file path
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js ed448d9
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less abb0637
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 05599e5
>
>
> Diff: https://reviews.apache.org/r/58613/diff/1/
>
>
> Testing
> -------
>
> Manually tested the changes
>
>
> Thanks,
>
> Supreeth Sharma
>
>
Re: Review Request 58613: Need to show appropriate error message while
deleting the workflow history in project manager
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58613/#review172649
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On April 21, 2017, 12:02 p.m., Supreeth Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58613/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 12:02 p.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changed the message to indicate that item is getting deleted only from the history and file will still be available in HDFS file path
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js ed448d9
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less abb0637
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 05599e5
>
>
> Diff: https://reviews.apache.org/r/58613/diff/1/
>
>
> Testing
> -------
>
> Manually tested the changes
>
>
> Thanks,
>
> Supreeth Sharma
>
>