You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/25 13:42:32 UTC

[GitHub] [flink] zentol commented on a change in pull request #8269: [FLINK-12285][test] Harden savepoint relevant test cases by explicitly canceling test job

zentol commented on a change in pull request #8269: [FLINK-12285][test] Harden savepoint relevant test cases by explicitly canceling test job
URL: https://github.com/apache/flink/pull/8269#discussion_r278555852
 
 

 ##########
 File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java
 ##########
 @@ -184,6 +185,9 @@ protected final void executeAndSavepoint(
 		} else {
 			FileUtils.moveFile(jobManagerSavepoint, new File(savepointPath));
 		}
+
+		client.cancel(jobGraph.getJobID());
+		waitJobCanceled(client, jobGraph.getJobID());
 
 Review comment:
   should not be necessary since the cluster is shut down afterwards

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services