[GitHub] [tomcat] stokito edited a comment on pull request #324: Change ETag format to Nginx like

[GitBox <gi...@apache.org>]

stokito edited a comment on pull request #324:
URL: https://github.com/apache/tomcat/pull/324#issuecomment-661312436


   > we cannot make any assumptions.
   
   But we already did when implemented the default method :) I used Tomcat for about 10 years in different projects and once even patched it for company's internal needs but never saw the AbstractResource. Can you elaborate how can this break anything?
   The most important is to check Spring but it uses it's own hash based [ShallowEtagHeaderFilter](https://github.com/spring-projects/spring-framework/blob/master/spring-web/src/main/java/org/springframework/web/filter/ShallowEtagHeaderFilter.java)
   
   > Why don't you delete the ETags send from Tomcat in nginx
   
   Never did that before but [here](https://stackoverflow.com/questions/33431722/in-nginx-etag-directive-doesnt-work-for-proxy-pass) is said that Nginx creates ETags only for local static files. I checked [docs](http://nginx.org/en/docs/http/ngx_http_proxy_module.html) and there is no anything about ETags.
   To create ETag from upstream Nginx needs a size (and it have it) and last mod time (can be retrieved from Last-Modifed but in my case BusyBox httpd not returns it).
   Anyway in my case some users will connect directly to upstream server. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org