You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/10/06 21:06:58 UTC
[GitHub] [nifi] pvillard31 opened a new pull request #4578: NIFI-7889 - ConsumeMQTT - use offer instead of add
pvillard31 opened a new pull request #4578:
URL: https://github.com/apache/nifi/pull/4578
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4578: NIFI-7889 - ConsumeMQTT - use offer instead of add
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4578:
URL: https://github.com/apache/nifi/pull/4578#issuecomment-755183678
Thanks for the review @turcsanyip - I updated the PR to address your comments. Also, after a discussion with @markap14, I decided to not expose the max offer time as a property and just use the magic number of '1 second' instead. Exposing the property could potentially offer the possibility for users to have a weird configuration leading to weird behaviours. Instead I added an additionalDetails page to still have the explanation around the processor's behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #4578: NIFI-7889 - ConsumeMQTT - use offer instead of add
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on a change in pull request #4578:
URL: https://github.com/apache/nifi/pull/4578#discussion_r552055174
##########
File path: nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
##########
@@ -82,6 +85,9 @@
@WritesAttribute(attribute=IS_DUPLICATE_ATTRIBUTE_KEY, description="Whether or not this message might be a duplicate of one which has already been received."),
@WritesAttribute(attribute=IS_RETAINED_ATTRIBUTE_KEY, description="Whether or not this message was from a current publisher, or was \"retained\" by the server as the last message published " +
"on the topic.")})
+@SystemResourceConsideration(resource = SystemResource.MEMORY, description = "The 'Max Queue Size' specifies the maximum number of messages that can be hold in memory by NiFi by a single "
+ + "instance of this processor. A high value for this property combined with a high number of concurrent tasks for the processor could represent a lot of data being stored in memory.")
Review comment:
I'm not sure if the number of concurrent tasks matters here because it is the processor instance that holds the buffer queue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #4578: NIFI-7889 - ConsumeMQTT - use offer instead of add
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on a change in pull request #4578:
URL: https://github.com/apache/nifi/pull/4578#discussion_r552055174
##########
File path: nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
##########
@@ -82,6 +85,9 @@
@WritesAttribute(attribute=IS_DUPLICATE_ATTRIBUTE_KEY, description="Whether or not this message might be a duplicate of one which has already been received."),
@WritesAttribute(attribute=IS_RETAINED_ATTRIBUTE_KEY, description="Whether or not this message was from a current publisher, or was \"retained\" by the server as the last message published " +
"on the topic.")})
+@SystemResourceConsideration(resource = SystemResource.MEMORY, description = "The 'Max Queue Size' specifies the maximum number of messages that can be hold in memory by NiFi by a single "
+ + "instance of this processor. A high value for this property combined with a high number of concurrent tasks for the processor could represent a lot of data being stored in memory.")
Review comment:
I'm not sure if the number of concurrent tasks matters here because it is the processor instance that holds the buffer queue.
Edit:
The processor annotated as `@TriggerSerially` so the concurrent tasks option is not relevant at all I believe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4578: NIFI-7889 - ConsumeMQTT - use offer instead of add
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4578:
URL: https://github.com/apache/nifi/pull/4578
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org