You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2017/10/11 14:11:19 UTC
[GitHub] carbondata pull request #1410: [WIP] FG interface updates
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/1410
[WIP] FG interface updates
User should implement AbstractFGDataMapFactory to prune till rowids.
More information about FG Datamap is mentioned in document https://docs.google.com/document/d/1Zsrru_EL-obnY0WKsCLX4T6DUM-breCtJM7AskaS-No/edit?usp=sharing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata datamap-fg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1410.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1410
----
commit 4f19b4a2c3e16f62bdff9c4415699ba52748dbe9
Author: ravipesala <ra...@gmail.com>
Date: 2017-10-11T13:37:22Z
Added FG interfaces
----
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590][Datamap] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1689/
---
[GitHub] carbondata pull request #1410: [WIP] FG interface updates
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1410#discussion_r144032502
--- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapType.java ---
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.core.datamap;
+
+public enum DataMapType {
+ CG,FG;
--- End diff --
If we have CoarseGrainDataMap and FineGrainDataMap interface, this enum is not needed. see next comment
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/466/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/333/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/334/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/460/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1088/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/459/
---
[GitHub] carbondata pull request #1410: [WIP] FG interface updates
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1410#discussion_r144032204
--- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
@@ -26,7 +26,7 @@
/**
* Datamap is an entity which can store and retrieve index data.
*/
-public interface DataMap {
+public interface DataMap<T extends Blocklet> {
--- End diff --
If there are only FG and CG datamap, I prefer to make another interface for FG datamap instead of adding generic. So there will be CoarseGrainDataMap and FineGrainDataMap interface
---
[GitHub] carbondata pull request #1410: [WIP] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1410#discussion_r145032414
--- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
@@ -26,7 +26,7 @@
/**
* Datamap is an entity which can store and retrieve index data.
*/
-public interface DataMap {
+public interface DataMap<T extends Blocklet> {
--- End diff --
Yes, but methods are same for both, so I have added Abstract classes for CG and FG to distinguish between them.
---
[GitHub] carbondata pull request #1410: [WIP] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1410#discussion_r145032517
--- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapType.java ---
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.core.datamap;
+
+public enum DataMapType {
+ CG,FG;
--- End diff --
It is used internally to simply by getting the type instead of using class type check
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590][Datamap] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/836/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590][Datamap] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1465/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1094/
---
[GitHub] carbondata issue #1410: [WIP] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/305/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590][Datamap] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1724/
---
[GitHub] carbondata pull request #1410: [WIP] FG interface updates
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1410#discussion_r144031420
--- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapType.java ---
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.core.datamap;
+
+public enum DataMapType {
+ CG,FG;
--- End diff --
It is better to use full name, it is more clear
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/766/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/335/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1089/
---
[GitHub] carbondata issue #1410: [WIP] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1059/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590][Datamap] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1279/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/341/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/467/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1179/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/461/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/342/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590][Datamap] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1088/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590][Datamap] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1469/
---
[GitHub] carbondata issue #1410: [WIP] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/458/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590][Datamap] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/832/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1086/
---
[GitHub] carbondata pull request #1410: [CARBONDATA-1590][Datamap] FG interface updat...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala closed the pull request at:
https://github.com/apache/carbondata/pull/1410
---
[GitHub] carbondata issue #1410: [WIP] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/429/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1296/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/548/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/336/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1095/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590][Datamap] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1133/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1410
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/661/
---
[GitHub] carbondata issue #1410: [CARBONDATA-1590] FG interface updates
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1410
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1087/
---