You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Maksim Zhuravkov (Jira)" <ji...@apache.org> on 2023/03/22 12:46:00 UTC
[jira] [Updated] (IGNITE-19096) Sql. Remove code that replaces placeholder values from ModifyNode.
[ https://issues.apache.org/jira/browse/IGNITE-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maksim Zhuravkov updated IGNITE-19096:
--------------------------------------
Description:
It is possible to remove default placeholders altogether and insert default value s for columns at the sql to relnode conversion phase.
*Note*
A) In order to avoid code duplication use TableDescriptorImpl::newColumnDefaultValue.
B) Calcite generates different RelNode trees for queries INSERT INTO tmp (a) VALUES (1) and INSERT INTO tmp (a, b) VALUES (1, DEFAULT). For the first query calcite supplies DEFAULT values by calling TableDescriptorImpl::newColumnDefaultValue, but for the second query it does not do it.
was:
After is complete it is possible to remove default placeholders altogether insert default value s for columns at the sql to relnode conversion phase.
*Note*
A) In order to avoid code duplication use TableDescriptorImpl::newColumnDefaultValue.
B) Calcite generates different RelNode trees for queries INSERT INTO tmp (a) VALUES (1) and INSERT INTO tmp (a, b) VALUES (1, DEFAULT). For the first query calcite supplies DEFAULT values by calling TableDescriptorImpl::newColumnDefaultValue, but for the second query it does not do it.
> Sql. Remove code that replaces placeholder values from ModifyNode.
> ------------------------------------------------------------------
>
> Key: IGNITE-19096
> URL: https://issues.apache.org/jira/browse/IGNITE-19096
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Reporter: Maksim Zhuravkov
> Priority: Minor
> Labels: calcite2-required, calcite3-required, ignite-3
> Fix For: 3.0.0-beta2
>
>
> It is possible to remove default placeholders altogether and insert default value s for columns at the sql to relnode conversion phase.
> *Note*
> A) In order to avoid code duplication use TableDescriptorImpl::newColumnDefaultValue.
> B) Calcite generates different RelNode trees for queries INSERT INTO tmp (a) VALUES (1) and INSERT INTO tmp (a, b) VALUES (1, DEFAULT). For the first query calcite supplies DEFAULT values by calling TableDescriptorImpl::newColumnDefaultValue, but for the second query it does not do it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)