You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/06 11:03:53 UTC
[GitHub] [arrow] rok commented on a diff in pull request #13440: ARROW-14819: [R] Binding for lubridate::qday
rok commented on code in PR #13440:
URL: https://github.com/apache/arrow/pull/13440#discussion_r914709427
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -533,6 +533,21 @@ test_that("extract yday from timestamp", {
)
})
+test_that("extract qday from timestamp", {
+ compare_dplyr_binding(
+ .input %>%
+ mutate(x = qday(datetime)) %>%
+ collect(),
+ test_df
Review Comment:
I love the idea of more complete tests! I would actually propose a development-time test suite (it seems overkill for CI) that tests every moment over the past century.
The test you're proposing however hits this bug where rounding kernels interpret 32 bit arrays as 64 bit ones ([ARROW-16142](https://issues.apache.org/jira/browse/ARROW-16142)) so I suppose we really need to fix this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org