You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/09/14 10:45:54 UTC
Review Request 62327: Checked TASK_KILLED in the test
`ROOT_INTERNET_CURL_PortMapper`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62327/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-7975
https://issues.apache.org/jira/browse/MESOS-7975
Repository: mesos
Description
-------
Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`.
Diffs
-----
src/tests/containerizer/cni_isolator_tests.cpp 636695f368d1c8acd9ed4ccfd1a449f375af8282
Diff: https://reviews.apache.org/r/62327/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 62327: Checked TASK_KILLED in the test
`ROOT_INTERNET_CURL_PortMapper`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62327/#review185440
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62326', '62327']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62327
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62327/logs/mesos-tests-stdout.log):
```
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (236 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (228 ms)
[----------] 30 tests from ContentType/SchedulerTest (24844 ms total)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (1055 ms)
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (1045 ms)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2218 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (141 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (154 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (362 ms total)
[----------] Global test environment tear-down
[==========] 627 tests from 66 test cases ran. (343045 ms total)
[ PASSED ] 626 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where GetParam() = application/json
1 FAILED TEST
YOU HAVE 174 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62327/logs/mesos-tests-stderr.log):
```
I0914 18:10:21.937254 13804 master.cpp:8418] Removing framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000 (default)
I0914 18:10:21.937254 13804 master.cpp:3267] Deactivating framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000 (default)
I0914 18:10:21.949259 13652 hierarchical.cpp:412] Deactivated framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000
I0914 18:10:21.949259 7980 slave.cpp:3235] Shutting down framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000
I0914 18:10:21.949259 13804 master.cpp:8993] Updating the state of task a2c63592-8dac-45fe-8d75-648527c00344 of framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0914 18:10:21.949259 7980 slave.cpp:5731] Shutting down executor 'default' of framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000 (via HTTP)
I0914 18:10:21.953253 13804 master.cpp:9087] Removing task a2c63592-8dac-45fe-8d75-648527c00344 with resources [{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}] of framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000 on agent 5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0 at slave(254)@10.3.1.5:55317 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 18:10:21.978255 13804 master.cpp:9116] Removing executor 'default' with resources [] of framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000 on agent 5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0 at slave(254)@10.3.1.5:55317 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 18:10:21.982254 13276 hierarchical.cpp:355] Removed framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000
E0914 18:10:21.983253 7980 scheduler.cpp:649] End-Of-File received from master. The master closed the event stream
I0914 18:10:21.984253 13276 scheduler.cpp:444] Re-detecting master
I0914 18:10:21.990254 13276 scheduler.cpp:470] New master detected at master@10.3.1.5:55317
I0914 18:10:22.002254 13276 slave.cpp:5407] Executor 'default' of framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000 exited with status 0
I0914 18:10:22.011286 13276 slave.cpp:5511] Cleaning up executor 'default' of framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000 (via HTTP)
W0914 18:10:22.012256 13804 master.cpp:7021] Ignoring unknown exited executor 'default' of framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000 on agent 5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0 at slave(254)@10.3.1.5:55317 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 18:10:22.013259 13652 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\GGk8ZW\slaves\5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0\frameworks\5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000\executors\default\runs\6d96e501-dfcb-4f86-b1b3-448fb0078ebd' for gc 6.99998828406222days in the future
I0914 18:10:22.014258 13276 slave.cpp:5607] Cleaning up framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000
I0914 18:10:22.014258 15848 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\GGk8ZW\slaves\5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0\frameworks\5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000\executors\default' for gc 6.99998826089185days in the future
I0914 18:10:22.015256 15236 status_update_manager.cpp:285] Closing status update streams for framework 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000
I0914 18:10:22.015256 13276 slave.cpp:861] Agent terminating
I0914 18:10:22.025255 7980 master.cpp:1321] Agent 5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0 at slave(254)@10.3.1.5:55317 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0914 18:10:22.025255 7980 master.cpp:3304] Disconnecting agent 5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0 at slave(254)@10.3.1.5:55317 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 18:10:22.026254 7980 master.cpp:3323] Deactivating agent 5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0 at slave(254)@10.3.1.5:55317 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 18:10:22.024255 15848 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\GGk8ZW\slaves\5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0\frameworks\5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000' for gc 6.99998824933926days in the future
I0914 18:10:22.027256 15596 hierarchical.cpp:690] Agent 5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0 deactivated
I0914 18:10:22.054260 15464 master.cpp:1163] Master terminating
I0914 18:10:22.058260 13652 hierarchical.cpp:626] Removed agent 5654c963-bb32-4299-aef7-1ad0e2fe83c9-S0
W0914 18:10:22.068256 15464 master.hpp:2761] Failed to close HTTP pipe for 5654c963-bb32-4299-aef7-1ad0e2fe83c9-0000 (default)
I0914 18:10:22.768270 15940 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Sept. 14, 2017, 10:45 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62327/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 10:45 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 636695f368d1c8acd9ed4ccfd1a449f375af8282
>
>
> Diff: https://reviews.apache.org/r/62327/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62327: Checked TASK_KILLED in the test
`ROOT_INTERNET_CURL_PortMapper`.
Posted by Qian Zhang <zh...@gmail.com>.
> On Sept. 30, 2017, 1:13 a.m., Vinod Kone wrote:
> > Can you also add tests for command and default executors to test this behavior?
Did you mean Docker and default executors? I think this patch has already covered command executor. I have posted two patches for Docker and default executor tests:
https://reviews.apache.org/r/62774/
https://reviews.apache.org/r/62775/
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62327/#review186695
-----------------------------------------------------------
On Sept. 14, 2017, 6:45 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62327/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 6:45 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 636695f368d1c8acd9ed4ccfd1a449f375af8282
>
>
> Diff: https://reviews.apache.org/r/62327/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62327: Checked TASK_KILLED in the test
`ROOT_INTERNET_CURL_PortMapper`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62327/#review186695
-----------------------------------------------------------
Can you also add tests for command and default executors to test this behavior?
- Vinod Kone
On Sept. 14, 2017, 10:45 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62327/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 10:45 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 636695f368d1c8acd9ed4ccfd1a449f375af8282
>
>
> Diff: https://reviews.apache.org/r/62327/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62327: Checked TASK_KILLED in the test
`ROOT_INTERNET_CURL_PortMapper`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62327/#review187217
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 14, 2017, 10:45 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62327/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 10:45 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 636695f368d1c8acd9ed4ccfd1a449f375af8282
>
>
> Diff: https://reviews.apache.org/r/62327/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>