You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/28 04:41:10 UTC

[GitHub] [arrow] rtyler opened a new pull request #7049: Avoid loading simd_load_set_invalid which doesn't exist on aarch64

rtyler opened a new pull request #7049:
URL: https://github.com/apache/arrow/pull/7049


       error[E0432]: unresolved import `crate::compute::util::simd_load_set_invalid`
       --> /home/tyler/.cargo/git/checkouts/arrow-3a9cfebb6b7b2bdc/2a8e37d/rust/arrow/src/compute/kernels/arithmetic.rs:42:5
       |
       42 | use crate::compute::util::simd_load_set_invalid;
       |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `simd_load_set_invalid` in `compute::util`
   
       Compiling thiserror v1.0.16
       error: aborting due to previous error


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] paddyhoran commented on pull request #7049: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64

Posted by GitBox <gi...@apache.org>.
paddyhoran commented on pull request #7049:
URL: https://github.com/apache/arrow/pull/7049#issuecomment-620734617


   Would you mind fixing the lint error also please (I know you didn't introduce this)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] paddyhoran commented on pull request #7049: ARROW-8617: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64

Posted by GitBox <gi...@apache.org>.
paddyhoran commented on pull request #7049:
URL: https://github.com/apache/arrow/pull/7049#issuecomment-620820630


   I'm going to merge this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] rtyler commented on pull request #7049: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64

Posted by GitBox <gi...@apache.org>.
rtyler commented on pull request #7049:
URL: https://github.com/apache/arrow/pull/7049#issuecomment-620733044


   https://issues.apache.org/jira/browse/ARROW-8617


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #7049: ARROW-8617: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #7049:
URL: https://github.com/apache/arrow/pull/7049#issuecomment-620756163


   > Would you mind fixing the lint error also please (I know you didn't introduce this)?
   
   We're fixing the lint error in #7024 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] rtyler commented on pull request #7049: Avoid loading simd_load_set_invalid which doesn't exist on aarch64

Posted by GitBox <gi...@apache.org>.
rtyler commented on pull request #7049:
URL: https://github.com/apache/arrow/pull/7049#issuecomment-620377892


   Fixing this also helps surface [ARROW-8610](https://issues.apache.org/jira/browse/ARROW-8610), which I have had a hell of a time fixing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] paddyhoran commented on pull request #7049: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64

Posted by GitBox <gi...@apache.org>.
paddyhoran commented on pull request #7049:
URL: https://github.com/apache/arrow/pull/7049#issuecomment-620694431


   Hi @rtyler,
   
   I was going to suggest disabling SIMD as auto-vectorization seems to be adding SIMD by itself, see #7037.  Also, on #7037 @nevi-me noticed the divide by zero problem.
   
   Can you open a JIRA so I can assign it to you and I'll get this merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org