You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/03/31 04:52:49 UTC
Review Request 32655: Refactor out launchHelper to make is usable
outside PortMappingIsolatorTest class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332
Repository: mesos
Description
-------
Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class
Diffs
-----
src/tests/port_mapping_tests.cpp 8192deac8d9b7ea1896bb62a8b5961ef90326fa4
Diff: https://reviews.apache.org/r/32655/diff/
Testing
-------
Thanks,
Paul Brett
Re: Review Request 32655: Refactor out launchHelper to make is usable
outside PortMappingIsolatorTest class
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/#review78322
-----------------------------------------------------------
Bad patch!
Reviews applied: [32655]
Failed command: ./support/apply-review.sh -n -r 32655
Error:
2015-03-31 03:25:16 URL:https://reviews.apache.org/r/32655/diff/raw/ [6570/6570] -> "32655.patch" [1]
error: patch failed: src/tests/port_mapping_tests.cpp:271
error: src/tests/port_mapping_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On March 31, 2015, 2:52 a.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32655/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 2:52 a.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
>
>
> Bugs: mesos-2332
> https://issues.apache.org/jira/browse/mesos-2332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class
>
>
> Diffs
> -----
>
> src/tests/port_mapping_tests.cpp 8192deac8d9b7ea1896bb62a8b5961ef90326fa4
>
> Diff: https://reviews.apache.org/r/32655/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 32655: Refactor out launchHelper to make is usable
outside PortMappingIsolatorTest class
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
-----------------------------------------------------------
(Updated March 31, 2015, 3:52 a.m.)
Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
Changes
-------
Remove dependency on having applied waitForFileCreation first
Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332
Repository: mesos
Description
-------
Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class
Diffs (updated)
-----
src/tests/port_mapping_tests.cpp f4124c3
Diff: https://reviews.apache.org/r/32655/diff/
Testing
-------
Thanks,
Paul Brett