You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/17 06:52:41 UTC

[GitHub] mistercrunch closed pull request #5649: fix multilayer viz backend error

mistercrunch closed pull request #5649: fix multilayer viz backend error
URL: https://github.com/apache/incubator-superset/pull/5649
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/utils.py b/superset/utils.py
index ca28a5a2c6..b1583084eb 100644
--- a/superset/utils.py
+++ b/superset/utils.py
@@ -958,7 +958,7 @@ def convert_legacy_filters_into_adhoc(fd):
                 fd['adhoc_filters'].append(to_adhoc(fd, 'SQL', clause))
 
             if filters in fd:
-                for filt in fd[filters]:
+                for filt in filter(lambda x: x is not None, fd[filters]):
                     fd['adhoc_filters'].append(to_adhoc(filt, 'SIMPLE', clause))
 
     for key in ('filters', 'having', 'having_filters', 'where'):


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org