You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/07/02 01:19:22 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #20413: [2.0] Tweak the argument order for softmax
Zha0q1 opened a new pull request #20413:
URL: https://github.com/apache/incubator-mxnet/pull/20413
`length` is also an input so changing
```
@set_module('mxnet.numpy_extension')
def softmax(data, axis=-1, length=None, temperature=None, use_length=False, dtype=None):
```
to
```
@set_module('mxnet.numpy_extension')
def softmax(data, length=None, axis=-1, temperature=None, use_length=False, dtype=None):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20413: [2.0] Tweak the argument order for softmax
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20413:
URL: https://github.com/apache/incubator-mxnet/pull/20413#issuecomment-872645548
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, centos-gpu, windows-gpu, clang, edge, windows-cpu, sanity, miscellaneous, unix-cpu, centos-cpu, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #20413: [2.0] Tweak the argument order for softmax
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #20413:
URL: https://github.com/apache/incubator-mxnet/pull/20413#issuecomment-873132939
> This is a breaking backwards incompatible change. Since, master is still beta, this should be okay; But, please capture this in upcoming release notes.
Yeah, I have sync'ed with @barry-jin who's tracking these changes ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 merged pull request #20413: [2.0] Tweak the argument order for softmax
Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #20413:
URL: https://github.com/apache/incubator-mxnet/pull/20413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org