You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/01 13:21:21 UTC

[GitHub] [flink] Myracle commented on a diff in pull request #19772: [FLINK-27579][client] The param client.timeout can not be set by dyna…

Myracle commented on code in PR #19772:
URL: https://github.com/apache/flink/pull/19772#discussion_r886799160


##########
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java:
##########
@@ -110,10 +110,6 @@ public class CliFrontend {
 
     private final Options customCommandLineOptions;
 
-    private final Duration clientTimeout;
-
-    private final int defaultParallelism;
-

Review Comment:
   I understand your considerations. But there will be two ways to configure parallelism in Cli. One is -p and the  other  is -Dparallelism.default which may confuse users. I prefer to not change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org