[GitHub] jgao54 commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?

[GitBox <gi...@apache.org>]

jgao54 commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?
URL: https://github.com/apache/airflow/pull/4421#issuecomment-453435480
 
 
   +1 on deleting under-utilized features :P 
   
   I see that CI/CD is still failing on ```sqlalchemy.exc.OperationalError: (_mysql_exceptions.OperationalError) (3730, "Cannot drop table 'users' referenced by a foreign key constraint 'known_event_ibfk_2' on table 'known_event'.") [SQL: '\nDROP TABLE users']```
   
   I think this is happening when attempting `airflow reset` in the ci/cd scripts, which in turn looks for all the tables that the sqlalchemy engine can find, and then delete them. But since the code for KnownEvent/KnownEventType models is removed, those tables didn't get detected/deleted, so now the `user` table can't get deleted because `known_event` has a reference to it. I think we will need to modify the ci/cd script and explicitly add a `drop table known_event; drop table known_event_type;` now... maybe there's a better way to do that. 
   
   In addition, @Fokko if you do a grep on `known_events` instead of `knownevent`, there are quite a few changes in the alembic scripts, but I don't see any problems with it since they are just creating/upgrading tables. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services