[GitHub] [httpcomponents-client] arturobernalg commented on a change in pull request #294: feature/method enum

[GitBox <gi...@apache.org>]

arturobernalg commented on a change in pull request #294:
URL: https://github.com/apache/httpcomponents-client/pull/294#discussion_r594970631



##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/protocol/RequestAddCookies.java
##########
@@ -78,7 +79,7 @@ public void process(final HttpRequest request, final EntityDetails entity, final
         Args.notNull(context, "HTTP context");
 
         final String method = request.getMethod();
-        if (method.equalsIgnoreCase("CONNECT") || method.equalsIgnoreCase("TRACE")) {
+        if (method.equalsIgnoreCase(Method.CONNECT.name()) || method.equalsIgnoreCase(Method.TRACE.name())) {

Review comment:
       Yep, changed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org