[GitHub] [pinot] jadami10 commented on pull request #7892: return 503 response from health check on shut down

[GitBox <gi...@apache.org>]

jadami10 commented on pull request #7892:
URL: https://github.com/apache/pinot/pull/7892#issuecomment-992669491


   @xiangfu0, i find the injection of a named boolean to just be a very complicated global variable. What do you think of this now? Rather than replacing the existing health check, this adds another healthcheck to the list that takes 2 callables that the broker can set to true/false as needed.
   
   I've also limited this to the broker since that's really the only component with this behavior of sleeping before shutting down.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org