You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/04 22:36:10 UTC
[GitHub] [incubator-superset] mistercrunch opened a new issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
mistercrunch opened a new issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941
## Screenshot
<img width="344" alt="Screen Shot 2020-12-04 at 2 33 54 PM" src="https://user-images.githubusercontent.com/487433/101222040-cae76780-363d-11eb-9aea-795ea6fc6823.png">
## Description
The icons (including the chevron) should all fit on one line floating right. I think it'd be safe to bump the width by at least 33%.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739072290
> so we dont have to increase panel width
i'd recommend to do some user research on how much space SQL Lab editor actually need. visually it gets really crowded when table, columns names are long, which is very common in larger organization. ideally the panel should be resizable, but we need to find a mid way solution for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
Steejay commented on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739069699
Agreed. some alignment issues here. I think there are some layout options we can play around with regarding table name and associated dropdown info so we dont have to increase panel width (to preserve space in smaller screen widths). i'll investigate and propose some options here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739063161
<img width="316" alt="Screen Shot 2020-12-04 at 2 38 27 PM" src="https://user-images.githubusercontent.com/67837651/101222542-d25b4080-363e-11eb-95e7-b9fcb3fb527f.png">
1. action section should not drop lower if the table name is long
2. chevron should not be in the different line
proposed solution:
1. increase the panel width as @mistercrunch suggested ^, % is tbd, design should chime in
2. apply max width on the table name. @graceguo-supercat @ktmud any thought on the long table name?
will let @Steejay to take over the discussion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] yousoph commented on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739066185
Agreed that the icon doesn't feel like it's in the right place.
Between these issues and #11725 and #11741, I think this left panel could use a little bit of design love. Will work with @Steejay to come up with a proposal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739072290
> so we dont have to increase panel width
i'd recommend to do some user research on how much space SQL Lab editor actually need. visually it gets really crowded when table, columns names are long, which is very common in larger organization. ideally the panel should be resizable, but we need to find a mid way solution for now. preserving information is very important.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay edited a comment on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
Steejay edited a comment on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739077523
as a quick fix for this issue, we should align chevron with the table name, positioned to the far right (see attached screenshot). To accommodate large names we can increase side panel by 33% for now. that should give us more space.
we will work with the community to continue exploring better ways to improve this side panel experience.
<img width="439" alt="Screen Shot 2020-12-04 at 3 31 58 PM" src="https://user-images.githubusercontent.com/60786102/101225312-f8d0aa00-3645-11eb-9d15-374a79d00a05.png">
cc @mistercrunch @yousoph
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739072290
> so we dont have to increase panel width
i'd recommend to do some user research on how much space SQL Lab editor actually need. visually it gets really crowded when table, columns names are long, which is very common in larger organization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-740385823
@geido 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc removed a comment on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-740385823
@geido 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
Steejay commented on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739077523
as a quick fix for this issue, we should align chevron with the table name, positioned to the far right (see attached screenshot). To accommodate large names we can increase side panel by 33% for now. that should give us more space.
we will work with the community to continue exploring better ways to improve this side panel experience.
<img width="439" alt="Screen Shot 2020-12-04 at 3 31 58 PM" src="https://user-images.githubusercontent.com/60786102/101225312-f8d0aa00-3645-11eb-9d15-374a79d00a05.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739063161
<img width="316" alt="Screen Shot 2020-12-04 at 2 38 27 PM" src="https://user-images.githubusercontent.com/67837651/101222542-d25b4080-363e-11eb-95e7-b9fcb3fb527f.png">
1. action section should not drop lower if the table name is long
2. chevron should not be in the different line
proposed solution:
1. increase the panel width as @mistercrunch suggested ^, % is tbd, design should chime in
2. apply max width on the table name. @graceguo-supercat @ktmud any thought on the long title?
will let @Steejay to take over the discussion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739072290
> so we dont have to increase panel width
i'd recommend to do some user research on how much space SQL Lab editor actually need. visually it gets really crowded when table, columns names are long, which is very common in larger organization. ideally it should be resizable, but we need to find a mid way solution for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739063161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11941: style(sqllab): fix the action icons in table schema (SQL Lab west panel)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11941:
URL: https://github.com/apache/incubator-superset/issues/11941#issuecomment-739063161
<img width="316" alt="Screen Shot 2020-12-04 at 2 38 27 PM" src="https://user-images.githubusercontent.com/67837651/101222542-d25b4080-363e-11eb-95e7-b9fcb3fb527f.png">
1. action section drop lower if the table name is long
2. chevron's position
proposed solution:
1. increase the panel width as @mistercrunch suggested ^, % is tbd, design should chime in
2. apply max width on the table name. @graceguo-supercat @ktmud any thought on the long table name?
will let @Steejay to take over the discussion
related issue https://github.com/apache/incubator-superset/issues/11741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org