You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "returnToInnocence (via GitHub)" <gi...@apache.org> on 2024/12/27 14:03:18 UTC
[PR] feature(llm): managed using poetry [incubator-hugegraph-ai]
returnToInnocence opened a new pull request, #149:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/149
# Background(Learn from Microsoft GraphRAG)
Originally, we used pip to install modules by downloading and installing all the dependencies. pip does not manage this, but simply removes the module, leaving behind a bunch of dependencies that were installed when the module was downloaded and installed, which can cause conflicts when installing other libraries with this legacy and no longer useful library
# References
1. https://python-poetry.org/docs/
2. https://github.com/microsoft/graphrag
3. https://python-poetry.org/docs/pyproject/
4. https://python-poetry.org/docs/dependency-specification/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] feat(llm): use poetry to manage the dependencies [incubator-hugegraph-ai]
Posted by "returnToInnocence (via GitHub)" <gi...@apache.org>.
returnToInnocence commented on PR #149:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/149#issuecomment-2589228084
> Perhaps we can add the command `poetry shell` after setting up the environment. Beginners may not know that they need to execute `poetry shell`.
@MrJs133 Thanks for your review and tips! 🫡
💡By creating a new virtual environment and using poetry to install the dependencies, instead of using poetry shell, we run it with `python3 -m hugegraph_llm.demo.rag_demo.app`. poetry shell should not be necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] feat(llm): use poetry to manage the dependencies [incubator-hugegraph-ai]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #149:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/149#discussion_r1918272715
##########
hugegraph-llm/README.md:
##########
Review Comment:
TODO: we need to improve the doc for poetry usage (for devs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] feature(llm): managed using poetry [incubator-hugegraph-ai]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #149:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/149#discussion_r1906961434
##########
hugegraph-llm/pyproject.toml:
##########
Review Comment:
Also update the README doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] feature(llm): managed using poetry [incubator-hugegraph-ai]
Posted by "ChenZiHong-Gavin (via GitHub)" <gi...@apache.org>.
ChenZiHong-Gavin commented on PR #149:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/149#issuecomment-2575767863
we don't need requirements.txt now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] feature(llm): managed using poetry [incubator-hugegraph-ai]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #149:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/149#discussion_r1913071540
##########
.licenserc.yaml:
##########
@@ -80,6 +80,7 @@ header: # `header` section is configurations for source codes license header.
- '**/META-INF/MANIFEST.MF'
- '.repository/**'
- '**/resources/**'
+ - '**/poetry.lock' # this is for poetry lock config
Review Comment:
```suggestion
- '**/poetry.lock'
```
##########
.github/workflows/check-dependencies.yml:
##########
@@ -22,6 +22,7 @@ jobs:
# Action will fail if dependencies don't match the list (we could choose only one of the following)
deny-licenses: GPL-3.0, AGPL-1.0, AGPL-3.0, LGPL-2.0, CC-BY-3.0
#allow-licenses: Apache-2.0, MIT
+
Review Comment:
```suggestion
```
##########
hugegraph-llm/README.md:
##########
@@ -17,8 +17,9 @@ graph systems and large language models.
## 2. Environment Requirements
-- python 3.9+ (better to use `3.10`)
+- python 3.10+(Gradio 5 requires Python 3.10 or higher)
Review Comment:
```suggestion
- python 3.10+ (not tested in 3.12)
```
##########
hugegraph-llm/README.md:
##########
@@ -17,8 +17,9 @@ graph systems and large language models.
## 2. Environment Requirements
-- python 3.9+ (better to use `3.10`)
+- python 3.10+(Gradio 5 requires Python 3.10 or higher)
- hugegraph-server 1.3+
Review Comment:
```suggestion
- hugegraph-server 1.3+ (better to use 1.5+)
```
##########
hugegraph-llm/requirements.txt:
##########
@@ -15,4 +15,4 @@ pyarrow~=17.0.0 # TODO: a temporary dependency for pandas, figure out why Import
pandas~=2.2.2
openpyxl~=3.1.5
pydantic-settings~=2.6.1
-apscheduler~=3.10.4
+apscheduler~=3.10.4
Review Comment:
```suggestion
apscheduler~=3.10.4
```
##########
.github/workflows/check-dependencies.yml:
##########
@@ -2,7 +2,7 @@ name: "License header & 3rd-party check"
on:
pull_request:
-
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] feat(llm): use poetry to manage the dependencies [incubator-hugegraph-ai]
Posted by "MrJs133 (via GitHub)" <gi...@apache.org>.
MrJs133 commented on PR #149:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/149#issuecomment-2587088049
Perhaps we can add the command `poetry shell` after setting up the environment.
Beginners may not know that they need to execute `poetry shell`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] feature(llm): managed using poetry [incubator-hugegraph-ai]
Posted by "returnToInnocence (via GitHub)" <gi...@apache.org>.
returnToInnocence commented on PR #149:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/149#issuecomment-2582861245
> we don't need requirements.txt now?
Yes, instead of the `requirements.txt`, we'll record versions through 'tool.poetry.dependencies' and `poetry.lock`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] feat(llm): use poetry to manage the dependencies [incubator-hugegraph-ai]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #149:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org