You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/04 14:08:40 UTC

[GitHub] [superset] michael-s-molina commented on a diff in pull request #22031: feat: Adds more customization properties to DropdownContainer

michael-s-molina commented on code in PR #22031:
URL: https://github.com/apache/superset/pull/22031#discussion_r1014064984


##########
superset-frontend/src/components/DropdownContainer/index.tsx:
##########
@@ -68,10 +71,18 @@ export interface DropdownContainerProps {
    * Option to customize the content of the popover.
    */
   popoverContent?: (overflowedItems: Item[]) => ReactElement;
+  /**
+   * Popover ref.
+   */
+  popoverRef?: RefObject<HTMLDivElement>;
   /**
    * Popover additional style properties.
    */
   popoverStyle?: CSSProperties;
+  /**
+   * Displayed count in the popover trigger.
+   */
+  popoverTriggerCount?: number;

Review Comment:
   External components will know which filters are in the dropdown using `onOverflowingStateChange` 😉 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org