You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2015/03/02 12:06:07 UTC

[3/5] git commit: updated refs/heads/master to 541c23e

Logical expression simplification, == true is redundant

Signed-off-by: Laszlo Hornyak <la...@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/5626a340
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/5626a340
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/5626a340

Branch: refs/heads/master
Commit: 5626a340dd271ec585f973dfa99a2a7fb45abac3
Parents: 3786aa0
Author: Laszlo Hornyak <la...@gmail.com>
Authored: Wed Feb 25 20:55:56 2015 +0100
Committer: Laszlo Hornyak <la...@gmail.com>
Committed: Fri Feb 27 19:38:12 2015 +0100

----------------------------------------------------------------------
 core/src/com/cloud/agent/api/routing/SetFirewallRulesCommand.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/5626a340/core/src/com/cloud/agent/api/routing/SetFirewallRulesCommand.java
----------------------------------------------------------------------
diff --git a/core/src/com/cloud/agent/api/routing/SetFirewallRulesCommand.java b/core/src/com/cloud/agent/api/routing/SetFirewallRulesCommand.java
index be85887..e030545 100644
--- a/core/src/com/cloud/agent/api/routing/SetFirewallRulesCommand.java
+++ b/core/src/com/cloud/agent/api/routing/SetFirewallRulesCommand.java
@@ -53,7 +53,7 @@ public class SetFirewallRulesCommand extends NetworkElementCommand {
              *  each entry format      <ip>:protocol:srcport:destport:scidr:
              *  reverted entry format  <ip>:reverted:0:0:0:
              */
-            if (fwTO.revoked() == true) {
+            if (fwTO.revoked()) {
                 StringBuilder sb = new StringBuilder();
                 /* This entry is added just to make sure atleast there will one entry in the list to get the ipaddress */
                 sb.append(fwTO.getSrcIp()).append(":reverted:0:0:0:");