You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/08/29 11:33:22 UTC
[jira] Created: (HARMONY-1307) [classlib][sql]
java.sql.Time.valueOf(String str) method should throw
IllegalArgumentException when the string is "15:43:12:34".
[classlib][sql] java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34".
--------------------------------------------------------------------------------------------------------------------------------
Key: HARMONY-1307
URL: http://issues.apache.org/jira/browse/HARMONY-1307
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Richard Liang
Hello,
java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34". I will try to fix this issue. Thanks a lot.
Best regards,
Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1307) [classlib][sql]
java.sql.Time.valueOf(String str) method should throw
IllegalArgumentException when the string is "15:43:12:34".
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1307?page=all ]
Richard Liang updated HARMONY-1307:
-----------------------------------
Attachment: Harmony-1307.diff
Hello,
Would you please try this patch? Thanks a lot.
Best regards,
Richard
> [classlib][sql] java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34".
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1307
> URL: http://issues.apache.org/jira/browse/HARMONY-1307
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Attachments: Harmony-1307.diff
>
>
> Hello,
> java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34". I will try to fix this issue. Thanks a lot.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1307) [classlib][sql]
java.sql.Time.valueOf(String str) method should throw
IllegalArgumentException when the string is "15:43:12:34".
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1307?page=comments#action_12432404 ]
Richard Liang commented on HARMONY-1307:
----------------------------------------
Paulex,
Thanks a lot, The fix looks good. And I have raised HARMONY-1358 to improve its performance.
Best regards,
Richard
> [classlib][sql] java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34".
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1307
> URL: http://issues.apache.org/jira/browse/HARMONY-1307
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: Paulex Yang
> Attachments: Harmony-1307.diff
>
>
> Hello,
> java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34". I will try to fix this issue. Thanks a lot.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1307) [classlib][sql]
java.sql.Time.valueOf(String str) method should throw
IllegalArgumentException when the string is "15:43:12:34".
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1307?page=all ]
Paulex Yang closed HARMONY-1307.
--------------------------------
Verified by Richard.
> [classlib][sql] java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34".
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1307
> URL: http://issues.apache.org/jira/browse/HARMONY-1307
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: Paulex Yang
> Attachments: Harmony-1307.diff
>
>
> Hello,
> java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34". I will try to fix this issue. Thanks a lot.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1307) [classlib][sql]
java.sql.Time.valueOf(String str) method should throw
IllegalArgumentException when the string is "15:43:12:34".
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1307?page=all ]
Paulex Yang reassigned HARMONY-1307:
------------------------------------
Assignee: Paulex Yang
> [classlib][sql] java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34".
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1307
> URL: http://issues.apache.org/jira/browse/HARMONY-1307
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: Paulex Yang
> Attachments: Harmony-1307.diff
>
>
> Hello,
> java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34". I will try to fix this issue. Thanks a lot.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1307) [classlib][sql]
java.sql.Time.valueOf(String str) method should throw
IllegalArgumentException when the string is "15:43:12:34".
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1307?page=all ]
Paulex Yang resolved HARMONY-1307.
----------------------------------
Resolution: Fixed
Richard, patch applied at revision r438404 together with patch for HARMONY-1305, because they are same issue for two similar classes, so I extract the common validation codes of them, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
Further, I saw possibilities to improve the performance of original Date and Time implementation, say, the SimpleDateFormat don't need to be instantiated every times, further the SimpleDateFormat is even not necessary to be used here, because in the validation part, the hour/minute/second(year/month/day for Date) value has been parsed. Please correct me if I'm wrong.
> [classlib][sql] java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34".
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1307
> URL: http://issues.apache.org/jira/browse/HARMONY-1307
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: Paulex Yang
> Attachments: Harmony-1307.diff
>
>
> Hello,
> java.sql.Time.valueOf(String str) method should throw IllegalArgumentException when the string is "15:43:12:34". I will try to fix this issue. Thanks a lot.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira