You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:30:14 UTC
[GitHub] [calcite-avatica-go] michaelmior opened a new pull request #53: [CALCITE-4147] Rename "master" branch to "main"
michaelmior opened a new pull request #53:
URL: https://github.com/apache/calcite-avatica-go/pull/53
See the associated JIRA case for full details as this will be coordinated across multiple Calcite subprojects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] michaelmior commented on a change in pull request #53: [CALCITE-4147] Rename "master" branch to "main"
Posted by GitBox <gi...@apache.org>.
michaelmior commented on a change in pull request #53:
URL: https://github.com/apache/calcite-avatica-go/pull/53#discussion_r462670972
##########
File path: docker.sh
##########
@@ -205,10 +205,10 @@ check_if_tag_exists(){
check_local_remote_are_even(){
REMOTE_COMMIT=$(git ls-remote $GITBOX_URL | head -1 | sed "s/[[:space:]]HEAD//")
- LOCAL_COMMIT=$(git rev-parse master)
+ LOCAL_COMMIT=$(git rev-parse main)
if [[ $REMOTE_COMMIT != $LOCAL_COMMIT ]]; then
- echo "Master in Apache repository is not even with local master"
+ echo "Master in Apache repository is not even with local main"
Review comment:
Good point. I was just searching for master lowercase so I missed this. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] F21 commented on a change in pull request #53: [CALCITE-4147] Rename "master" branch to "main"
Posted by GitBox <gi...@apache.org>.
F21 commented on a change in pull request #53:
URL: https://github.com/apache/calcite-avatica-go/pull/53#discussion_r462647404
##########
File path: docker.sh
##########
@@ -205,10 +205,10 @@ check_if_tag_exists(){
check_local_remote_are_even(){
REMOTE_COMMIT=$(git ls-remote $GITBOX_URL | head -1 | sed "s/[[:space:]]HEAD//")
- LOCAL_COMMIT=$(git rev-parse master)
+ LOCAL_COMMIT=$(git rev-parse main)
if [[ $REMOTE_COMMIT != $LOCAL_COMMIT ]]; then
- echo "Master in Apache repository is not even with local master"
+ echo "Master in Apache repository is not even with local main"
Review comment:
I think `Master` should also be replaced here :)
##########
File path: docker.sh
##########
@@ -205,10 +205,10 @@ check_if_tag_exists(){
check_local_remote_are_even(){
REMOTE_COMMIT=$(git ls-remote $GITBOX_URL | head -1 | sed "s/[[:space:]]HEAD//")
- LOCAL_COMMIT=$(git rev-parse master)
+ LOCAL_COMMIT=$(git rev-parse main)
if [[ $REMOTE_COMMIT != $LOCAL_COMMIT ]]; then
- echo "Master in Apache repository is not even with local master"
+ echo "Master in Apache repository is not even with local main"
Review comment:
@michaelmior I think `Master` should also be replaced here :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org