You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/18 00:58:52 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31218: [SPARK-34147][SQL][TEST] Keep data partitioning in TPCDSQueryBenchmak when CBO is enabled

HyukjinKwon commented on a change in pull request #31218:
URL: https://github.com/apache/spark/pull/31218#discussion_r559268316



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
##########
@@ -44,9 +45,6 @@ import org.apache.spark.util.Utils
  */
 object TPCDSQueryBenchmark extends SqlBasedBenchmark with Logging {
 
-  private lazy val warehousePath =
-    Utils.createTempDir(namePrefix = "spark-warehouse").getAbsolutePath

Review comment:
       Why did we remove this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org