You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2019/06/26 08:26:33 UTC
[Bug 7728] New: Remove HashCash support from trunk
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
Bug ID: 7728
Summary: Remove HashCash support from trunk
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Plugins
Assignee: dev@spamassassin.apache.org
Reporter: apache@hege.li
Target Milestone: Undefined
I propose removing HashCash.pm completely and any mention of it in trunk/4.0. I
don't think anyone used this even 15 years ago. Leaving things lingering as
"unsupported legacy code" is not practical either.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
--- Comment #9 from Henrik Krohns <ap...@hege.li> ---
I've added check to load_plugin() to warn gracefully about things like this.
# Bug 7728
if ($package eq 'Mail::SpamAssassin::Plugin::HashCash') {
warn "plugin: $package is deprecated, remove loadplugin clause from your
configuration\n";
return;
}
Sending lib/Mail/SpamAssassin/PluginHandler.pm
Transmitting file data .done
Committing transaction...
Committed revision 1874052.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
--- Comment #12 from Kevin A. McGrail <km...@apache.org> ---
Ahh good point. Ignore me. I've been installing 3.4.4, 3.4.5 and trunk and
mixed up my brain.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
--- Comment #7 from jidanni@jidanni.org ---
OK, from now on I'll do rm -rf $PREFIX before doing the make stuff. Removes 90%
of the cruft mounting up too!
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
--- Comment #10 from Kevin A. McGrail <km...@apache.org> ---
Henrik, can you submit that to 3.4 as well? I'm coming up for air and will get
3.4.5 built.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
--- Comment #1 from AXB <ax...@gmail.com> ---
my +1 to removing
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
jidanni@jidanni.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jidanni@jidanni.org
--- Comment #5 from jidanni@jidanni.org ---
All I know is now I am getting warnings
warn: plugin: failed to parse plugin (from @INC): Can't locate
Mail/SpamAssassin/Plugin/Hashcash.pm in @INC
because though present in
share/perl/5.28.1/Mail/SpamAssassin/Plugin
it is not present in
share/perl/5.30.0/Mail/SpamAssassin/Plugin
however other parts of the code are still trying to invoke it, despite
svn update; make clean; perl Makefile.PL; make; make install
etc.
I probably have to remove everything and reinstall to finally stop the errors!
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
Bill Cole <bi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |billcole@apache.org
--- Comment #6 from Bill Cole <bi...@apache.org> ---
(In reply to jidanni from comment #5)
> I probably have to remove everything and reinstall to finally stop the
> errors!
OR just fix your init.pre file to remove the directive to load the HashCash
plugin.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
Henrik Krohns <ap...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
CC| |apache@hege.li
Status|NEW |RESOLVED
--- Comment #4 from Henrik Krohns <ap...@hege.li> ---
Done.
Notice that trunk/rules/init.pre with hashcash removed completely will end up
in next 3.4.3 rc release, so it will not be active for any _new_ 3.4.3
installations. Old installations will not have init.pre overwritten, so I don't
feel there is any reason to include this in 3.4 UPGRADE notes.
It's also removed from current rules. In the 0.00000001% chance that someone is
actually using this, they can create the rules locally..
Sending trunk/MANIFEST
Sending trunk/UPGRADE
Sending trunk/USAGE
Sending trunk/rules/30_text_de.cf
Sending trunk/rules/30_text_pt_br.cf
Sending trunk/rules/50_scores.cf
Sending trunk/rules/init.pre
Sending trunk/rulesrc/10_force_active.cf
Sending trunk/spamassassin.raw
Sending trunk/t/all_modules.t
Sending trunk/t/data/01_test_rules.cf
Sending trunk/t/data/01_test_rules.pre
Sending trunk/t/debug.t
Transmitting file data .............done
Committing transaction...
Committed revision 1862148.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@apache.org
--- Comment #2 from Kevin A. McGrail <km...@apache.org> ---
I don't even know what it does because I think the term HashCash has morphed
over the decades.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
--- Comment #8 from Henrik Krohns <ap...@hege.li> ---
(In reply to jidanni from comment #7)
> OK, from now on I'll do rm -rf $PREFIX before doing the make stuff. Removes
> 90% of the cruft mounting up too!
There's no reason to do that, and you also destroy your settings etc.
Removing HashCash was a rare occurence of removing ancient plugin/code that
should never be run, even if some user has it loaded in some configs. Simply
remove the loadplugin clause, there's nothing more to it.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |giovanni@paclan.it
--- Comment #3 from Giovanni Bechis <gi...@paclan.it> ---
+1 to kill it
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7728] Remove HashCash support from trunk
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7728
--- Comment #11 from Henrik Krohns <ap...@hege.li> ---
(In reply to Kevin A. McGrail from comment #10)
> Henrik, can you submit that to 3.4 as well? I'm coming up for air and will
> get 3.4.5 built.
Hashcash is still found in 3.4 branch, I don't see any need touch anything?
--
You are receiving this mail because:
You are the assignee for the bug.