You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Sergey Beryozkin (JIRA)" <ji...@apache.org> on 2017/10/30 20:05:00 UTC

[jira] [Comment Edited] (CXF-7501) Cannot inject field in ContainerRequestFilter

    [ https://issues.apache.org/jira/browse/CXF-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225656#comment-16225656 ] 

Sergey Beryozkin edited comment on CXF-7501 at 10/30/17 8:04 PM:
-----------------------------------------------------------------

There's a very strong push at the JAX-RS spec level to do 'Inject' only. Look at Jersey docs, they probably do not even have Context anywhere now. This is why it can make sense to make this new interface doc-ed as expected to change, it might now, but we should anticipate @Context will be gone entirely


was (Author: sergey_beryozkin):
There's a very strong push at the JAX-RS spec level to do 'Inject' only. Look at Jersey docs, they probably do not even have Context anywhere now. 

> Cannot inject field in ContainerRequestFilter
> ---------------------------------------------
>
>                 Key: CXF-7501
>                 URL: https://issues.apache.org/jira/browse/CXF-7501
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.1.10, 3.2.0
>         Environment: Linux Mint 64 bit, TomEE Plus 7.0.3, JavaEE 7 application using MVC specification and reference implementation(Libs Attached)
>            Reporter: Jeyvison Nascimento
>            Assignee: Andriy Redko
>              Labels: cdi
>             Fix For: 3.1.14, 3.2.1
>
>         Attachments: javax-mvc.jar, ozark.jar
>
>
> Hey folks.
> We found a weird behavior while running MVC specification(JSR 371) on TomEE witch CXF. We have a *ContainerRequestFilter* defined called *JaxRsContextFilter* 
> {code:java}
> @PreMatching
> @Priority(0)
> public class JaxRsContextFilter implements ContainerRequestFilter {
>     @Inject
>     private JaxRsContextProducer jaxRsContextProducer;
>     @Context
>     private Configuration configuration;
>     @Context
>     private HttpServletRequest request;
>     @Context
>     private HttpServletResponse response;
>     public JaxRsContextFilter() {
>     }
>     public void filter(ContainerRequestContext requestContext) throws IOException {
>         this.jaxRsContextProducer.populate(this.configuration, this.request, this.response);
>     }
> }
> {code}
> You can see that we have a JaxRsContextProducer annotated to be injected as a field in our object but when JAXRSUtils is called to run the the container filters it injects the fields annotated as *@Context* , not the fields annotated with *@Inject*.
> {code:java}
>  for (ProviderInfo<ContainerRequestFilter> filter : containerFilters) {
>                 try {
>                     InjectionUtils.injectContexts(filter.getProvider(), filter, m);
>                     filter.getProvider().filter(context);
>                 } catch (IOException ex) {
>                     throw ExceptionUtils.toInternalServerErrorException(ex, null); 
>                 }
> {code}
> It causes our filter(*JaxRsContextFilter*) to throw a NullPointerException when filtering the request because it uses the producer to perform some actions in  this operation.
> I believe this field should be injected as well, not only the *@Context* fields.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)