You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/16 06:04:02 UTC

[GitHub] [incubator-dolphinscheduler] WilliamChen-luckbob commented on pull request #4779: [Fix] while repeat running, the global parameters will not set to the user specified start parameters.

WilliamChen-luckbob commented on pull request #4779:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4779#issuecomment-779604814


   @CalvinKirs 
   Hope that I have properly fix someting.
   
   I think that, instead of using default global parameters, rerun function of a process instance should use it's start parameters which was specified by user at the first time when user started this process instance.
   
   So far I have added and tested the code in RepeatRunning situation only.
   In this commitment, if we specified starting parameters at the beginning of running a process instance, we can then rerun this process instance again with that starting param. 
   
   That may make debug much easier by sending the same parameter then rerun process instance by one click.
   
   Looking forward to your review if you got some time, thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org